Skip to content

model-cli reference docs #22681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 2, 2025
Merged

model-cli reference docs #22681

merged 7 commits into from
Jun 2, 2025

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented May 21, 2025

Description

Adds model-cli reference docs.

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented May 21, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 2645703
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/683d5946b726440008679690
😎 Deploy Preview https://deploy-preview-22681--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@crazy-max crazy-max added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label May 21, 2025
@github-actions github-actions bot added area/cli Relates to the CLI client hugo Updates related to hugo dependencies Vendoring, packaging updates area/config labels May 21, 2025
@crazy-max crazy-max force-pushed the model-cli branch 3 times, most recently from ed76536 to 6378aeb Compare May 26, 2025 11:08
@crazy-max crazy-max changed the title [DNM] model-cli reference docs model-cli reference docs May 28, 2025
@crazy-max crazy-max marked this pull request as ready for review May 28, 2025 08:13
@crazy-max crazy-max removed the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label May 28, 2025
ArthurFlag
ArthurFlag previously approved these changes May 28, 2025
Copy link
Contributor

@ArthurFlag ArthurFlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

crazy-max and others added 3 commits May 28, 2025 10:56
@crazy-max
Copy link
Member Author

Rebased to fix conflict after #22687 was merged

@crazy-max crazy-max requested a review from ArthurFlag May 28, 2025 08:57
@crazy-max
Copy link
Member Author

vale seems to fail: https://github.com/docker/docs/actions/runs/15295918829/job/43024912108?pr=22681

image

But don't know why if someone wants to take a look.

@ArthurFlag
Copy link
Contributor

@crazy-max we're good now 🚀

ArthurFlag
ArthurFlag previously approved these changes May 28, 2025
@@ -5,4 +5,3 @@ Show Docker Model Runner disk usage


<!---MARKER_GEN_END-->

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? This is vendored and should not be edited manually 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-save in my editor trimmed stuff when I was testing the vale fix... Should I revert this? (do we care since it's autogen?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(do we care since it's autogen?)

If you mean autogen on ci that's not the case, it's only done through make vendor or hugo mod vendor so should not be edited whatsoever. But I see there is nothing atm to validate that vendor dir is pristine. We should look at this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, i will create a ticket. I also reverted the formatting.

ArthurFlag
ArthurFlag previously approved these changes May 28, 2025
@ArthurFlag ArthurFlag merged commit 5516d06 into docker:main Jun 2, 2025
14 checks passed
@crazy-max crazy-max deleted the model-cli branch June 2, 2025 08:35
@crazy-max crazy-max mentioned this pull request Jun 3, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ai area/cli Relates to the CLI client area/config area/tests dependencies Vendoring, packaging updates hugo Updates related to hugo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants