Skip to content

DMR: GUI docs #22685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

DMR: GUI docs #22685

merged 1 commit into from
Jun 4, 2025

Conversation

ArthurFlag
Copy link
Contributor

@ArthurFlag ArthurFlag commented May 22, 2025 •
edited
Loading

Description

Add GUI docs for Docker Models.

https://deploy-preview-22685--docsdocker.netlify.app/ai/model-runner/

@netlify Netlify
Copy link

netlify bot commented May 22, 2025 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 56b278d
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/68404f9e8a2f46000809fb40
😎 Deploy Preview https://deploy-preview-22685--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ArthurFlag ArthurFlag marked this pull request as draft May 22, 2025 07:03
@ArthurFlag ArthurFlag changed the title dmr: gui docs DMR: GUI docs May 22, 2025
@github-actions github-actions bot added area/compose Relates to docker-compose.yml spec or docker-compose binary area/tests labels May 23, 2025
@aevesdocker aevesdocker added this to the 4.42 milestone May 23, 2025
@ArthurFlag ArthurFlag marked this pull request as ready for review May 26, 2025 14:51
@ArthurFlag ArthurFlag requested a review from aevesdocker as a code owner May 26, 2025 14:51
@ArthurFlag ArthurFlag force-pushed the ENGDOCS-2644-dmr-gui branch from cadd436 to e7a6ded Compare May 27, 2025 09:42
aevesdocker
aevesdocker reviewed May 27, 2025
View reviewed changes
Copy link
Collaborator

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits, rest LGTM

@ArthurFlag ArthurFlag force-pushed the ENGDOCS-2644-dmr-gui branch from 82479ad to 3204ed7 Compare May 28, 2025 09:55
@github-actions github-actions bot added area/build Relates to Dockerfiles or docker build command area/desktop Issue affects a desktop edition of Docker. E.g docker for mac dependencies Vendoring, packaging updates area/billing labels May 28, 2025
@ArthurFlag ArthurFlag force-pushed the ENGDOCS-2644-dmr-gui branch from 3204ed7 to 462529c Compare May 28, 2025 09:58
kiview
kiview reviewed May 28, 2025
View reviewed changes
@ArthurFlag ArthurFlag force-pushed the ENGDOCS-2644-dmr-gui branch 2 times, most recently from 413118a to 45ba5e7 Compare May 28, 2025 12:30
xenoscopic
xenoscopic approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@xenoscopic xenoscopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sarahsanders-docker
sarahsanders-docker previously approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArthurFlag ArthurFlag force-pushed the ENGDOCS-2644-dmr-gui branch 2 times, most recently from 4dbe384 to 854c81b Compare June 2, 2025 09:29
@aevesdocker
Copy link
Collaborator

@ArthurFlag we have a branch conflict 😱 - once you've resolved it I can approve this and be all ready for the release (either later today or tomorrow)

@ArthurFlag ArthurFlag force-pushed the ENGDOCS-2644-dmr-gui branch from 854c81b to 96d7f4d Compare June 3, 2025 09:16
@ArthurFlag
Copy link
Contributor Author

@aevesdocker done :)

aevesdocker
aevesdocker previously approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@ArthurFlag ArthurFlag force-pushed the ENGDOCS-2644-dmr-gui branch from 96d7f4d to ab8195c Compare June 3, 2025 09:44
@ArthurFlag ArthurFlag force-pushed the ENGDOCS-2644-dmr-gui branch from ab8195c to 56b278d Compare June 4, 2025 13:52
@aevesdocker aevesdocker merged commit 4174e54 into docker:main Jun 4, 2025
14 checks passed
ArthurFlag added a commit to ArthurFlag/docker-docs that referenced this pull request Jun 4, 2025
@ArthurFlag
DMR: GUI docs (docker#22685)
f1c99c7 
<!--Delete sections as needed -->

Add GUI docs for Docker Models.

https://deploy-preview-22685--docsdocker.netlify.app/ai/model-runner/
aevesdocker added a commit that referenced this pull request Jun 4, 2025
@aevesdocker
Revert "DMR: GUI docs (#22685)"
186f39a 
This reverts commit 4174e54.
@aevesdocker aevesdocker mentioned this pull request Jun 4, 2025
Merged
ArthurFlag pushed a commit that referenced this pull request Jun 4, 2025
@aevesdocker
Revert "DMR: GUI docs" (#22768)
e17aca8 
Reverts #22685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview left review comments

@xenoscopic xenoscopic xenoscopic approved these changes

@aevesdocker aevesdocker aevesdocker approved these changes

@sarahsanders-docker sarahsanders-docker sarahsanders-docker left review comments

Assignees
No one assigned
Labels
area/ai area/billing area/build Relates to Dockerfiles or docker build command area/compose Relates to docker-compose.yml spec or docker-compose binary area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security area/tests dependencies Vendoring, packaging updates status/review
Projects
None yet
Milestone
4.42
Development

Successfully merging this pull request may close these issues.
5 participants
@ArthurFlag @aevesdocker @xenoscopic @kiview @sarahsanders-docker