Skip to content

Fix 28.2.0 rel notes, trusted_interfaces separator ':' not space #22742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

robmry
Copy link
Contributor

@robmry robmry commented Jun 2, 2025

Description

Fix release notes for moby 28.2.0 ... the separator for option com.docker.network.bridge.trusted_host_interfaces changed from space to colon following review - but I forgot to update the description release notes.

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/engine Issue affects Docker engine/daemon label Jun 2, 2025
Copy link

netlify bot commented Jun 2, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 1811cb2
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/683d6a8d1924f40008710dc5
😎 Deploy Preview https://deploy-preview-22742--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@@ -82,7 +82,7 @@ For a full list of pull requests and changes in this release, refer to the relev

### Networking

- Add bridge network option `"com.docker.network.bridge.trusted_host_interfaces"`, accepting a space-separated list of interface names. These interfaces have direct access to published ports on container IP addresses. [moby/moby#49832](https://github.com/moby/moby/pull/49832)
- Add bridge network option `"com.docker.network.bridge.trusted_host_interfaces"`, accepting a colon-separated list of interface names. These interfaces have direct access to published ports on container IP addresses. [moby/moby#49832](https://github.com/moby/moby/pull/49832)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we picked colon, and not comma (I know we tried to remove use of colon in various options, although that was for key:value, which we changed to key=value).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma is allowed in a Linux interface name. So, I went for a space separator initially but Cory preferred colon because "the kernel uses colons to delimit lists of netdevs in certain ioctls", moby/moby#49832 (comment).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, I was wondering if comma would've been a valid part of the name. Yeah, guess it makes sense then to use something else.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 0c2f5fc into docker:main Jun 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issue affects Docker engine/daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants