Fix 28.2.0 rel notes, trusted_interfaces separator ':' not space #22742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Murray <[email protected]>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ArthurFlag
approved these changes
Jun 2, 2025
thaJeztah
reviewed
Jun 2, 2025
| @@ -82,7 +82,7 @@ For a full list of pull requests and changes in this release, refer to the relev | |||
|
|
|||
| ### Networking | |||
|
|
|||
| - Add bridge network option `"com.docker.network.bridge.trusted_host_interfaces"`, accepting a space-separated list of interface names. These interfaces have direct access to published ports on container IP addresses. [moby/moby#49832](https://github.com/moby/moby/pull/49832) | |||
| - Add bridge network option `"com.docker.network.bridge.trusted_host_interfaces"`, accepting a colon-separated list of interface names. These interfaces have direct access to published ports on container IP addresses. [moby/moby#49832](https://github.com/moby/moby/pull/49832) | |||
There was a problem hiding this comment.
Curious why we picked colon, and not comma (I know we tried to remove use of colon in various options, although that was for key:value, which we changed to key=value).
There was a problem hiding this comment.
Comma is allowed in a Linux interface name. So, I went for a space separator initially but Cory preferred colon because "the kernel uses colons to delimit lists of netdevs in certain ioctls", moby/moby#49832 (comment).
There was a problem hiding this comment.
Ah, right, I was wondering if comma would've been a valid part of the name. Yeah, guess it makes sense then to use something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix release notes for moby 28.2.0 ... the separator for option
com.docker.network.bridge.trusted_host_interfaceschanged from space to colon following review - but I forgot to update the description release notes.Related issues or tickets
Reviews