Skip to content

fix: netlify builds #22757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sarahsanders-docker
Copy link
Collaborator

Description

  • Fixes broken Netlify builds

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e7161f3
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/683f56b0fbc2310008e03878
😎 Deploy Preview https://deploy-preview-22757--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the area/release Relates to CI or deployment label Jun 3, 2025
netlify.toml Outdated
@@ -7,6 +7,7 @@ NODE_ENV = "production"
HUGO_VERSION = "0.141.0"
HUGO_ENABLEGITINFO = "true"
HUGO_ENVIRONMENT = "preview"
SECRETS_SCAN_SMART_DETECTION_ENABLED = "false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm; do we know what it tripped over? Did it detect a possible secret anywhere as false positive (if so, could we update those docs?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinpointed where it tripped over, trying something with my next commit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting; could it be related to that code being changed to "text" highlighting? I just saw this PR;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could try if it likes yaml or toml for those (I think it's effective either of those)

Copy link
Collaborator Author

@sarahsanders-docker sarahsanders-docker Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this started happening before that PR went out, I encountered it first thing this morning (9am EST)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's weird; also don't see any keywords in there that I could see as "this may be interpreted as security". At most the formatting (starting with -- interpreted as "start of private key" or something silly like that)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaml and toml aren't working 😭

@github-actions github-actions bot added the area/contrib Relates to the Docker style guide and contribution guidelines label Jun 3, 2025
@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review June 3, 2025 20:18
@sarahsanders-docker sarahsanders-docker enabled auto-merge (squash) June 3, 2025 20:23
@sarahsanders-docker
Copy link
Collaborator Author

I have it set to auto merge & squash @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahsanders-docker sarahsanders-docker merged commit 0c151dc into docker:main Jun 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/contrib Relates to the Docker style guide and contribution guidelines area/release Relates to CI or deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants