-
Notifications
You must be signed in to change notification settings - Fork 7.8k
fix: netlify builds #22757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: netlify builds #22757
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
netlify.toml
Outdated
@@ -7,6 +7,7 @@ NODE_ENV = "production" | |||
HUGO_VERSION = "0.141.0" | |||
HUGO_ENABLEGITINFO = "true" | |||
HUGO_ENVIRONMENT = "preview" | |||
SECRETS_SCAN_SMART_DETECTION_ENABLED = "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm; do we know what it tripped over? Did it detect a possible secret anywhere as false positive (if so, could we update those docs?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pinpointed where it tripped over, trying something with my next commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting; could it be related to that code being changed to "text" highlighting? I just saw this PR;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could try if it likes yaml
or toml
for those (I think it's effective either of those)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this started happening before that PR went out, I encountered it first thing this morning (9am EST)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's weird; also don't see any keywords in there that I could see as "this may be interpreted as security". At most the formatting (starting with --
interpreted as "start of private key" or something silly like that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yaml and toml aren't working 😭
I have it set to auto merge & squash @thaJeztah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Reviews