Skip to content

Reuse Utf8JsonWriter #9607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2019
Merged

Reuse Utf8JsonWriter #9607

merged 1 commit into from
Apr 21, 2019

Conversation

BrennanConroy
Copy link
Member

Fixes #9602

Current master:

Method Mean Error StdDev Op/s Gen 0 Allocated
WriteResponse_MemoryBufferWriter 793.3 ns 26.85 ns 78.74 ns 1,260,614.3 0.0486 256 B

This PR:

Method Mean Error StdDev Op/s Gen 0 Allocated
WriteResponse_MemoryBufferWriter 712.9 ns 14.16 ns 37.31 ns 1,402,624.0 0.0267 144 B

@BrennanConroy BrennanConroy marked this pull request as ready for review April 20, 2019 22:27
@BrennanConroy BrennanConroy requested a review from ahsonkhan April 20, 2019 22:27
@BrennanConroy BrennanConroy merged commit c300c8c into master Apr 21, 2019
@BrennanConroy BrennanConroy deleted the brecon/reuseWriter branch April 21, 2019 18:49
@analogrelay analogrelay added this to the 3.0.0-preview5 milestone Apr 22, 2019
@ahsonkhan ahsonkhan mentioned this pull request Feb 1, 2020
Closed
@gfoidl gfoidl mentioned this pull request Jun 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@davidfowl davidfowl davidfowl approved these changes

@JamesNK JamesNK JamesNK approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@mikaelm12 mikaelm12 Awaiting requested review from mikaelm12

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-preview5
Development

Successfully merging this pull request may close these issues.

Reuse Utf8JsonWriter's in SignalR
5 participants
@BrennanConroy @halter73 @davidfowl @JamesNK @analogrelay