Support new context resolve handler #8126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
approved these changes
Apr 2, 2025
genlu
changed the title
dibarbet
reviewed
Apr 3, 2025
| @@ -77,26 +88,35 @@ export function registerCopilotContextProviders( | |||
| devkit.activate().then(async (devKitExports) => { | |||
| try { | |||
| // Check if the Copilot Language Server extension is installed and has the correct capabilities | |||
| let hasCapabilities = false; | |||
| // 0 means not support, 1 means old version, 2 means new version | |||
| let hasCapabilities = 0; | |||
There was a problem hiding this comment.
instead of this, maybe have let resolveMethod: string | undefined = undefined; and set the method name below if the version matches? Then you also don't have to do the hasCapabilities === 1 below
| capability.version === newResolveContextMethodSupportedVersion | ||
| ) { | ||
| hasCapabilities = 2; | ||
| channel.debug(`supported 'roslyn/resolveContext@2' method found in capabilities.json`); |
There was a problem hiding this comment.
need to make a note here - this PR requires a Roslyn version bump with the handler present in it (otherwise this request may fail).
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the change in dotnet/roslyn#77973