Start extension host debug instance without Yarn #15686
Open
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Before the switch to NPM, the extension host plugin setup for Electron used Yarn's wrapping of the
node_modules/.binbinaries to invoke thetheiacommand. With the switch to NPM, that no longer works, and extension host debugging doesn't successfully launch a new window in Electron. This PR adds a script to the Electronpackage.jsonto invoketheia startwith no additional arguments and then uses it in the extension host debug startup process.How to test
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers