Minor changes to support running system tests with x-pack-apm #11638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @axw? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
axw
force-pushed
the
systemtest-es-plugin
branch
from
c39ab5f to
537f2d3
Compare
If the span or transaction field is missing or null, create a new object rather than omitting the duration.
These are some of the changes needed for the system tests to pass when using the x-pack-apm ES plugin templates and pipelines, rather than the Fleet integration package ones. There are more changes, which we'll add later when we remove the data streams from the integration package.
axw
force-pushed
the
systemtest-es-plugin
branch
from
537f2d3 to
dec8bb7
Compare
axw
commented
Sep 14, 2023
| var names []string | ||
| for _, hit := range result.Hits.Hits { | ||
| names = append(names, gjson.GetBytes(hit.RawSource, "error.grouping_name").String()) | ||
| values := hit.Fields["error.grouping_name"] |
There was a problem hiding this comment.
Note for reviewers: I made this change because in the Elasticserach plugin, we are using a script field which is evaluated at index time. It ends up in fields, but not in _source.
axw
commented
Sep 14, 2023
| source: `{"@timestamp": "2022-02-15", "observer": {"version": "8.2.0"}, "processor": {"event": "transaction"}}`, | ||
| // No transaction.* field, no event.duration: set transaction.duration.us to zero. | ||
| source: `{"@timestamp": "2022-02-15", "observer": {"version": "8.2.0"}, "processor": {"event": "transaction"}}`, | ||
| expectedTransactionDurationUS: 0.0, |
There was a problem hiding this comment.
Note for reviewers: there's a small functional change here, which won't actually ever manifest in reality - transactions and spans always have a transaction or span object defined.
dmathieu
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
These are some of the changes needed for the system tests to pass when using the x-pack-apm ES plugin templates and pipelines (elastic/elasticsearch#97546), rather than the Fleet integration package ones. There will be more changes needed, which we'll add later when we remove the data streams from the integration package.
Checklist
- [ ] Update CHANGELOG.asciidocapmpackagehave been made)- [ ] Documentation has been updatedHow to test these changes
N/A
Related issues
elastic/elasticsearch#97546