Skip to content

Conversation

axw
Copy link
Member

@axw axw commented Jul 13, 2021

Motivation/summary

Bump the integration package version, and update it to use apm-server.auth.* config. This is a prerequisite for updating the package for anonymous auth support (#5623).

Split some of the Fleet/Elastic Agent setup out of the system test TestFleetIntegration, into a separate function which can be reused. There's also a fix to the package policy creation to set defaults correctly, to avoid integration editor UI errors such as elastic/kibana#105384.

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Documentation has been updated

How to test these changes

Test that secret token and API Key auth continue to work in the Fleet integration.

Related issues

#5623

Split some of the Fleet/Elastic Agent setup
out of TestFleetIntegration, into a separate
function which can be reused. Fix the package
policy creation to set defaults correctly.
@axw axw force-pushed the systemtest-fleet-vars branch from 374226a to 7587c3c Compare July 13, 2021 12:46
@axw axw marked this pull request as ready for review July 13, 2021 12:47
@axw axw requested a review from a team July 13, 2021 12:47
@ghost
Copy link

ghost commented Jul 13, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-13T15:09:57.064+0000

  • Duration: 41 min 34 sec

  • Commit: 7587c3c

Test stats 🧪

Test Results
Failed 0
Passed 5881
Skipped 14
Total 5895

Trends 🧪

Image of Build Times

Image of Tests

@axw axw merged commit 166ebbb into elastic:master Jul 14, 2021
@axw axw deleted the systemtest-fleet-vars branch July 14, 2021 00:49
mergify bot pushed a commit that referenced this pull request Jul 14, 2021
* apmpackage: bump to 0.4.0, use apm-server.auth config

* systemtest: refactor and fix Fleet tests

Split some of the Fleet/Elastic Agent setup
out of TestFleetIntegration, into a separate
function which can be reused. Fix the package
policy creation to set defaults correctly.

(cherry picked from commit 166ebbb)
axw added a commit that referenced this pull request Jul 14, 2021
* apmpackage: bump to 0.4.0, use apm-server.auth config

* systemtest: refactor and fix Fleet tests

Split some of the Fleet/Elastic Agent setup
out of TestFleetIntegration, into a separate
function which can be reused. Fix the package
policy creation to set defaults correctly.

(cherry picked from commit 166ebbb)

Co-authored-by: Andrew Wilkins <[email protected]>
@stuartnelson3 stuartnelson3 self-assigned this Aug 30, 2021
@stuartnelson3
Copy link
Contributor

Confirmed with BC3

@stuartnelson3 stuartnelson3 removed their assignment Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants