package: correct default TLS protocols (add 1.3, remove 1.0) #8577

marclop · 2022-07-11T07:19:37Z

Motivation/summary

Adds support for TLSv1.3 and removes TLSv1.0 from the
list of default TLS protocols.

Checklist

~~- [ ] Update CHANGELOG.asciidoc~~

Update package changelog.yml (only if changes to apmpackage have been made)
~~- [ ] Documentation has been updated~~

How to test these changes

make build-package
docker-compose up -d
cd systemtest/cmd/runapm; go run main.go
curl -v --tlsv1.3 localhost:<runapm port>

Related issues

#8569

Adds support for `TLSv1.3` in the list of default TLS protocols. Signed-off-by: Marc Lopez Rubio <[email protected]>

ghost · 2022-07-11T07:47:05Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-07-13T06:39:03.520+0000
Duration: 27 min 35 sec

Test stats 🧪

Test	Results
Failed	0
Passed	4109
Skipped	13
Total	4122

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/hey-apm : Run the hey-apm benchmark.
/package : Generate and publish the docker images.
/test windows : Build & tests on Windows.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

ghost · 2022-07-11T07:47:12Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`42/42`)	💚
Files	91.96% (`183/199`)	👍
Classes	93.435% (`427/457`)	👍
Methods	89.08% (`1085/1218`)	👎 -0.082
Lines	76.77% (`13312/17340`)	👎 -0.052
Conditionals	100.0% (`0/0`)	💚

ghost · 2022-07-11T07:47:15Z

📚 Go benchmark report

Diff with the main branch

name                                                                                            old time/op    new time/op     delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
RUMV3Processor/rum_events.ndjson-12                                                                161µs ±18%      211µs ±18%  +30.82%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-metadata.ndjson-12             555ns ± 1%      577ns ± 3%   +3.87%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/optional-timestamps.ndjson-12         3.69µs ± 3%     3.86µs ± 2%   +4.69%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/transactions.ndjson-12                12.9µs ± 1%     13.0µs ± 1%   +1.27%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/errors_rum.ndjson-12                  5.03µs ± 0%     5.41µs ± 4%   +7.53%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-event.ndjson-12          3.04µs ±10%     3.27µs ± 6%   +7.56%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/events.ndjson-12                      19.8µs ± 1%     19.6µs ± 1%   -1.46%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum_2.ndjson-12    2.75µs ± 3%     2.88µs ± 6%   +4.88%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
WriteTransaction/nop_codec_big_tx-12                                                               792ns ±32%      440ns ±38%  -44.46%  (p=0.032 n=5+5)
ReadEvents/json_codec_big_tx/10_events-12                                                          132µs ±22%      180µs ±25%  +36.47%  (p=0.016 n=5+5)
IsTraceSampled/sampled-12                                                                         77.1ns ± 1%     78.0ns ± 1%   +1.14%  (p=0.032 n=5+5)
IsTraceSampled/unknown-12                                                                          366ns ± 2%      357ns ± 2%   -2.62%  (p=0.032 n=5+5)

name                                                                                            old alloc/op   new alloc/op    delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
ModelIndexer/BestCompression-12                                                                   2.75kB ± 1%     2.70kB ± 1%   -1.85%  (p=0.008 n=5+5)
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/invalid-metadata-2.ndjson-12                                                     2.95kB ± 1%     2.90kB ± 1%   -1.56%  (p=0.008 n=5+5)
BackendProcessor/metadata.ndjson-12                                                               5.37kB ± 1%     5.48kB ± 3%   +2.12%  (p=0.032 n=5+5)
RUMV3Processor/rum_errors.ndjson-12                                                               10.1kB ± 1%     10.3kB ± 1%   +1.84%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/transactions_spans.ndjson-12          57.6kB ± 0%     57.4kB ± 0%   -0.47%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-event-type.ndjson-12          4.06kB ± 2%     4.16kB ± 1%   +2.54%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/minimal-service.ndjson-12             11.7kB ± 1%     11.8kB ± 1%   +1.29%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/ratelimit.ndjson-12                    116kB ± 1%      115kB ± 1%   -0.69%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                            old allocs/op  new allocs/op   delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                            old speed      new speed       delta
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
RUMV3Processor/rum_events.ndjson-12                                                             24.6MB/s ±16%   18.8MB/s ±21%  -23.66%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-metadata.ndjson-12           803MB/s ± 1%    774MB/s ± 3%   -3.70%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/optional-timestamps.ndjson-12        278MB/s ± 3%    266MB/s ± 2%   -4.50%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/transactions.ndjson-12               439MB/s ± 1%    434MB/s ± 1%   -1.25%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/errors_rum.ndjson-12                 377MB/s ± 0%    351MB/s ± 4%   -6.95%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-event.ndjson-12         193MB/s ±11%    179MB/s ± 6%   -7.25%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/events.ndjson-12                     375MB/s ± 1%    380MB/s ± 1%   +1.47%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum_2.ndjson-12   406MB/s ± 3%    388MB/s ± 6%   -4.59%  (p=0.032 n=5+5)

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

apmpackage/apm/manifest.yml

simitt · 2022-07-11T14:49:46Z

As the APM Integration became GA in 7.16, I suggest to backport and release patches for apm packages of version 7.16, 7.17 and all 8.0, 8.1, 8.2, 8.3.

Signed-off-by: Marc Lopez Rubio <[email protected]>

…n-default-apmpackage-settigns

Signed-off-by: Marc Lopez Rubio <[email protected]>

…igns

…n-default-apmpackage-settigns

Signed-off-by: Marc Lopez Rubio <[email protected]>

Adds support for `TLSv1.3` and removes `TLSv1.0` from the list of default TLS protocols. Signed-off-by: Marc Lopez Rubio <[email protected]> (cherry picked from commit 8ac7cf4)

…8601) Adds support for `TLSv1.3` and removes `TLSv1.0` from the list of default TLS protocols. Signed-off-by: Marc Lopez Rubio <[email protected]> (cherry picked from commit 8ac7cf4) Co-authored-by: Marc Lopez Rubio <[email protected]>

…8605) Adds support for `TLSv1.3` and removes `TLSv1.0` from the list of default TLS protocols. Signed-off-by: Marc Lopez Rubio <[email protected]> (cherry picked from commit 8ac7cf4) Co-authored-by: Marc Lopez Rubio <[email protected]>

…8602) Adds support for `TLSv1.3` and removes `TLSv1.0` from the list of default TLS protocols. Signed-off-by: Marc Lopez Rubio <[email protected]> (cherry picked from commit 8ac7cf4) Co-authored-by: Marc Lopez Rubio <[email protected]>

…backport #8577) (#8606) Adds support for `TLSv1.3` and removes `TLSv1.0` from the list of default TLS protocols. Signed-off-by: Marc Lopez Rubio <[email protected]> (cherry picked from commit 8ac7cf4)

…8604) Adds support for `TLSv1.3` and removes `TLSv1.0` from the list of default TLS protocols. Signed-off-by: Marc Lopez Rubio <[email protected]> (cherry picked from commit 8ac7cf4) Co-authored-by: Marc Lopez Rubio <[email protected]>

…8603) Adds support for `TLSv1.3` and removes `TLSv1.0` from the list of default TLS protocols. Signed-off-by: Marc Lopez Rubio <[email protected]> (cherry picked from commit 8ac7cf4) Co-authored-by: Marc Lopez Rubio <[email protected]>

package: Support TLSv1.3 in default TLS protocols

0b80381

Adds support for `TLSv1.3` in the list of default TLS protocols. Signed-off-by: Marc Lopez Rubio <[email protected]>

marclop added bug backport-8.3 Automated backport with mergify labels Jul 11, 2022

marclop assigned marclop and unassigned marclop Jul 11, 2022

bmorelli25 mentioned this pull request Jul 11, 2022

docs: correct default TLS support #8569

Merged

simitt reviewed Jul 11, 2022

View reviewed changes

apmpackage/apm/manifest.yml Outdated Show resolved Hide resolved

marclop added 2 commits July 12, 2022 09:42

Remove TLSv1.0

fe95b3a

Signed-off-by: Marc Lopez Rubio <[email protected]>

Merge remote-tracking branch 'upstream/main' into f/support-tls-1.3-i…

a148334

…n-default-apmpackage-settigns

marclop added backport-7.16 Automated backport with mergify to the 7.16 branch backport-8.0 Automated backport with mergify backport-8.1 Automated backport with mergify backport-8.2 Automated backport with mergify backport-7.17 Automated backport with mergify to the 7.17 branch labels Jul 12, 2022

marclop changed the title ~~package: Support TLSv1.3 in default TLS protocols~~ package: correct default TLS protocols (add 1.3, remove 1.0) Jul 12, 2022

marclop added 2 commits July 12, 2022 11:53

Update systemtests

8e9a49e

Signed-off-by: Marc Lopez Rubio <[email protected]>

Merge branch 'main' into f/support-tls-1.3-in-default-apmpackage-sett…

0dde013

…igns

simitt approved these changes Jul 12, 2022

View reviewed changes

marclop added 2 commits July 13, 2022 14:38

Merge remote-tracking branch 'upstream/main' into f/support-tls-1.3-i…

667513a

…n-default-apmpackage-settigns

remove changelog entry (to be done in branch)

3ba0459

Signed-off-by: Marc Lopez Rubio <[email protected]>

marclop enabled auto-merge (squash) July 13, 2022 06:39

marclop merged commit 8ac7cf4 into elastic:main Jul 13, 2022

marclop deleted the f/support-tls-1.3-in-default-apmpackage-settigns branch July 13, 2022 07:05

mergify bot mentioned this pull request Jul 13, 2022

[8.3] package: correct default TLS protocols (add 1.3, remove 1.0) (backport #8577) #8601

Merged

mergify bot mentioned this pull request Jul 13, 2022

[8.2] package: correct default TLS protocols (add 1.3, remove 1.0) (backport #8577) #8602

Merged

mergify bot mentioned this pull request Jul 13, 2022

[8.1] package: correct default TLS protocols (add 1.3, remove 1.0) (backport #8577) #8603

Merged

mergify bot mentioned this pull request Jul 13, 2022

[8.0] package: correct default TLS protocols (add 1.3, remove 1.0) (backport #8577) #8604

Merged

mergify bot mentioned this pull request Jul 13, 2022

[7.17] package: correct default TLS protocols (add 1.3, remove 1.0) (backport #8577) #8605

Merged

mergify bot mentioned this pull request Jul 13, 2022

[7.16] package: correct default TLS protocols (add 1.3, remove 1.0) (backport #8577) #8606

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

package: correct default TLS protocols (add 1.3, remove 1.0) #8577

package: correct default TLS protocols (add 1.3, remove 1.0) #8577

Uh oh!

marclop commented Jul 11, 2022 •

edited

Loading

Uh oh!

ghost commented Jul 11, 2022 •

edited by ghost

Loading

Build stats

Test stats 🧪

Uh oh!

ghost commented Jul 11, 2022 •

edited by ghost

Loading

Uh oh!

ghost commented Jul 11, 2022 •

edited by ghost

Loading

Uh oh!

Uh oh!

simitt commented Jul 11, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

package: correct default TLS protocols (add 1.3, remove 1.0) #8577

package: correct default TLS protocols (add 1.3, remove 1.0) #8577

Uh oh!

Conversation

marclop commented Jul 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation/summary

Checklist

How to test these changes

Related issues

Uh oh!

ghost commented Jul 11, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

ghost commented Jul 11, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

ghost commented Jul 11, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Go benchmark report

Uh oh!

Uh oh!

simitt commented Jul 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marclop commented Jul 11, 2022 •

edited

Loading

ghost commented Jul 11, 2022 •

edited by ghost

Loading

ghost commented Jul 11, 2022 •

edited by ghost

Loading

ghost commented Jul 11, 2022 •

edited by ghost

Loading

simitt commented Jul 11, 2022 •

edited

Loading