Skip to content

Prevent exporting dashboards from 8.8 #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Prevent exporting dashboards from 8.8 #1359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e42e627
Prevent exporting dashboards from 8.8
jsoriano Jul 17, 2023
96964fa
Reuse versions in error message
jsoriano Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions internal/export/dashboards.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (
"os"
"path/filepath"

"github.com/Masterminds/semver/v3"

"github.com/elastic/elastic-package/internal/common"
"github.com/elastic/elastic-package/internal/kibana"
"github.com/elastic/elastic-package/internal/logger"
Expand All @@ -30,6 +32,14 @@ func Dashboards(kibanaClient *kibana.Client, dashboardsIDs []string) error {
return fmt.Errorf("reading package manifest failed (path: %s): %w", packageRoot, err)
}

versionInfo, err := kibanaClient.Version()
if err != nil {
return fmt.Errorf("getting Kibana version information: %w", err)
}
if err := checkKibanaVersion(versionInfo); err != nil {
return fmt.Errorf("cannot import from this Kibana version: %w", err)
}

objects, err := kibanaClient.Export(dashboardsIDs)
if err != nil {
return fmt.Errorf("exporting dashboards using Kibana client failed: %w", err)
Expand All @@ -51,6 +61,23 @@ func Dashboards(kibanaClient *kibana.Client, dashboardsIDs []string) error {
return nil
}

func checkKibanaVersion(info kibana.VersionInfo) error {
version, err := semver.NewVersion(info.Number)
if err != nil {
return fmt.Errorf("cannot parse version %s: %w", info.Number, err)
}

minVersion := semver.MustParse("8.8.0")
maxVersion := semver.MustParse("8.10.0")
if version.LessThan(maxVersion) && !version.LessThan(minVersion) {
// See:
// - https://github.com/elastic/elastic-package/issues/1354
// - https://github.com/elastic/kibana/pull/161969
return fmt.Errorf("packages with dashboards exported since Kibana %s may not be installed till %s, please export the dashboard/s from a different version", minVersion, maxVersion)
}
return nil
}

func applyTransformations(ctx *transformationContext, objects []common.MapStr) ([]common.MapStr, error) {
return newObjectTransformer().
withContext(ctx).
Expand Down