Skip to content

Conversation

PeteGillinElastic
Copy link
Member

This removes the option fallback_to_default_databases on the geoip ingest processor has been deprecated and ignored since 8.0.0.

This removes the option `fallback_to_default_databases` on the `geoip`
ingest processor has been deprecated and ignored since 8.0.0.
@PeteGillinElastic PeteGillinElastic added >breaking :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v9.0.0 labels Nov 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @PeteGillinElastic, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@PeteGillinElastic PeteGillinElastic marked this pull request as ready for review November 4, 2024 13:00
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Nov 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@joegallo joegallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any uses of DEFAULT_DATABASES_DEPRECATION_MESSAGE remain after this change? If not, I think you should remove the variable definition, too.

@PeteGillinElastic
Copy link
Member Author

Do any uses of DEFAULT_DATABASES_DEPRECATION_MESSAGE remain after this change? If not, I think you should remove the variable definition, too.

Good call, done.

@PeteGillinElastic PeteGillinElastic enabled auto-merge (squash) November 4, 2024 15:18
@PeteGillinElastic PeteGillinElastic enabled auto-merge (squash) November 4, 2024 15:58
@PeteGillinElastic PeteGillinElastic merged commit 599ab7a into elastic:main Nov 4, 2024
16 checks passed
@PeteGillinElastic PeteGillinElastic deleted the v9-geoip-fallback branch November 11, 2024 12:19
jozala pushed a commit that referenced this pull request Nov 13, 2024
This removes the option `fallback_to_default_databases` on the `geoip`
ingest processor has been deprecated and ignored since 8.0.0.
@leemthompo
Copy link
Contributor

@PeteGillinElastic is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes]

@PeteGillinElastic
Copy link
Member Author

@PeteGillinElastic is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes]

I think this depends on the policy for the serverless changelog. This property was deprecated and ignored since 8.0.0, so nobody should have been using it in serverless. I don't know whether this should be mentioned or not.

@PeteGillinElastic
Copy link
Member Author

Also, this change was made in November, before serverless GA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants