-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Remove ignored fallback option on GeoIP processor #116112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ignored fallback option on GeoIP processor #116112
Conversation
This removes the option `fallback_to_default_databases` on the `geoip` ingest processor has been deprecated and ignored since 8.0.0.
Hi @PeteGillinElastic, I've created a changelog YAML for you. Note that since this PR is labelled |
Pinging @elastic/es-data-management (Team:Data Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do any uses of DEFAULT_DATABASES_DEPRECATION_MESSAGE
remain after this change? If not, I think you should remove the variable definition, too.
Good call, done. |
This removes the option `fallback_to_default_databases` on the `geoip` ingest processor has been deprecated and ignored since 8.0.0.
@PeteGillinElastic is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
I think this depends on the policy for the serverless changelog. This property was deprecated and ignored since 8.0.0, so nobody should have been using it in serverless. I don't know whether this should be mentioned or not. |
Also, this change was made in November, before serverless GA. |
This removes the option
fallback_to_default_databases
on thegeoip
ingest processor has been deprecated and ignored since 8.0.0.