-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Rename deprecation index template #125606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The dataset name for the deprecation logs index was previously renamed from `deprecation.elasticsearch` to `elasticsearch.deprecation` in order to follow the pattern of `product.group`. The deprecation index template, however, was not updated. This causes indexing errors once upgraded to 9.0 due to the dataset name having changed on a constant_keyword field. In order to avoid that mismatch, this commit renames the deprecation indexing datastream to match the dataset name. The old template is kept in place, but marked as deprecated, so that any deprecation logs written during upgrading to 9.x will continue to be indexed into the old datastream. closes elastic#125445
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Hi @rjernst, I've created a changelog YAML for you. Note that since this PR is labelled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming CI is happy
💔 Backport failed
You can use sqren/backport to manually backport by running |
The dataset name for the deprecation logs index was previously renamed from `deprecation.elasticsearch` to `elasticsearch.deprecation` in order to follow the pattern of `product.group`. The deprecation index template, however, was not updated. This causes indexing errors once upgraded to 9.0 due to the dataset name having changed on a constant_keyword field. In order to avoid that mismatch, this commit renames the deprecation indexing datastream to match the dataset name. The old template is kept in place, but marked as deprecated, so that any deprecation logs written during upgrading to 9.x will continue to be indexed into the old datastream. closes elastic#125445
The dataset name for the deprecation logs index was previously renamed from `deprecation.elasticsearch` to `elasticsearch.deprecation` in order to follow the pattern of `product.group`. The deprecation index template, however, was not updated. This causes indexing errors once upgraded to 9.0 due to the dataset name having changed on a constant_keyword field. In order to avoid that mismatch, this commit renames the deprecation indexing datastream to match the dataset name. The old template is kept in place, but marked as deprecated, so that any deprecation logs written during upgrading to 9.x will continue to be indexed into the old datastream. closes #125445
The dataset name for the deprecation logs index was previously renamed from `deprecation.elasticsearch` to `elasticsearch.deprecation` in order to follow the pattern of `product.group`. The deprecation index template, however, was not updated. This causes indexing errors once upgraded to 9.0 due to the dataset name having changed on a constant_keyword field. In order to avoid that mismatch, this commit renames the deprecation indexing datastream to match the dataset name. The old template is kept in place, but marked as deprecated, so that any deprecation logs written during upgrading to 9.x will continue to be indexed into the old datastream. closes elastic#125445
@rjernst is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
No, this is an operational change. |
The dataset name for the deprecation logs index was previously renamed from
deprecation.elasticsearch
toelasticsearch.deprecation
in order to follow the pattern ofproduct.group
. The deprecation index template, however, was not updated. This causes indexing errors once upgraded to 9.0 due to the dataset name having changed on a constant_keyword field. In order to avoid that mismatch, this commit renames the deprecation indexing datastream to match the dataset name. The old template is kept in place, but marked as deprecated, so that any deprecation logs written during upgrading to 9.x will continue to be indexed into the old datastream.closes #125445