Skip to content

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Mar 25, 2025

The dataset name for the deprecation logs index was previously renamed from deprecation.elasticsearch to elasticsearch.deprecation in order to follow the pattern of product.group. The deprecation index template, however, was not updated. This causes indexing errors once upgraded to 9.0 due to the dataset name having changed on a constant_keyword field. In order to avoid that mismatch, this commit renames the deprecation indexing datastream to match the dataset name. The old template is kept in place, but marked as deprecated, so that any deprecation logs written during upgrading to 9.x will continue to be indexed into the old datastream.

closes #125445

The dataset name for the deprecation logs index was previously renamed
from `deprecation.elasticsearch` to `elasticsearch.deprecation` in
order to follow the pattern of `product.group`. The deprecation index
template, however, was not updated. This causes indexing errors once
upgraded to 9.0 due to the dataset name having changed on a
constant_keyword field. In order to avoid that mismatch, this commit
renames the deprecation indexing datastream to match the dataset name.
The old template is kept in place, but marked as deprecated, so that any
deprecation logs written during upgrading to 9.x will continue to be
indexed into the old datastream.

closes elastic#125445
@rjernst rjernst added >breaking :Core/Infra/Core Core issues without another label auto-backport Automatically create backport pull requests when merged v9.0.1 v9.1.0 labels Mar 25, 2025
@rjernst rjernst requested review from dakrone and masseyke March 25, 2025 18:35
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 25, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @rjernst, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI is happy

@rjernst rjernst merged commit d4aa1e6 into elastic:main Mar 25, 2025
17 checks passed
@rjernst rjernst deleted the deprecations/template_rename branch March 25, 2025 21:17
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125606

rjernst added a commit to rjernst/elasticsearch that referenced this pull request Mar 26, 2025
The dataset name for the deprecation logs index was previously renamed
from `deprecation.elasticsearch` to `elasticsearch.deprecation` in
order to follow the pattern of `product.group`. The deprecation index
template, however, was not updated. This causes indexing errors once
upgraded to 9.0 due to the dataset name having changed on a
constant_keyword field. In order to avoid that mismatch, this commit
renames the deprecation indexing datastream to match the dataset name.
The old template is kept in place, but marked as deprecated, so that any
deprecation logs written during upgrading to 9.x will continue to be
indexed into the old datastream.

closes elastic#125445
elasticsearchmachine pushed a commit that referenced this pull request Mar 26, 2025
The dataset name for the deprecation logs index was previously renamed
from `deprecation.elasticsearch` to `elasticsearch.deprecation` in
order to follow the pattern of `product.group`. The deprecation index
template, however, was not updated. This causes indexing errors once
upgraded to 9.0 due to the dataset name having changed on a
constant_keyword field. In order to avoid that mismatch, this commit
renames the deprecation indexing datastream to match the dataset name.
The old template is kept in place, but marked as deprecated, so that any
deprecation logs written during upgrading to 9.x will continue to be
indexed into the old datastream.

closes #125445
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
The dataset name for the deprecation logs index was previously renamed
from `deprecation.elasticsearch` to `elasticsearch.deprecation` in
order to follow the pattern of `product.group`. The deprecation index
template, however, was not updated. This causes indexing errors once
upgraded to 9.0 due to the dataset name having changed on a
constant_keyword field. In order to avoid that mismatch, this commit
renames the deprecation indexing datastream to match the dataset name.
The old template is kept in place, but marked as deprecated, so that any
deprecation logs written during upgrading to 9.x will continue to be
indexed into the old datastream.

closes elastic#125445
@leemthompo
Copy link
Contributor

@rjernst is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes]

@rjernst
Copy link
Member Author

rjernst commented Apr 11, 2025

No, this is an operational change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >breaking :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation logger rejects new entries after upgrade to 9.0 unless deprecation log data stream is rolled over

4 participants