Skip to content

Fix switch in KeywordFieldMapperTests #88747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2022
Merged

Fix switch in KeywordFieldMapperTests #88747

merged 1 commit into from
Jul 22, 2022

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 22, 2022

Closes #88746

@dnhatn dnhatn added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.4.0 labels Jul 22, 2022
@dnhatn dnhatn requested a review from nik9000 July 22, 2022 20:31
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Jul 22, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

mayya-sharipova
mayya-sharipova approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnhatn Thanks Nhat.

@dnhatn
Copy link
Member Author

dnhatn commented Jul 22, 2022

Thanks Mayya!

@dnhatn dnhatn removed the request for review from nik9000 July 22, 2022 20:42
@dnhatn dnhatn added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 22, 2022
@elasticsearchmachine elasticsearchmachine merged commit 1eb591d into elastic:master Jul 22, 2022
@dnhatn dnhatn deleted the fix-checkstyle branch July 22, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayya-sharipova mayya-sharipova mayya-sharipova approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeywordFieldMapperTests has switch with impossible branches
3 participants
@dnhatn @elasticsearchmachine @mayya-sharipova