Skip to content

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Jan 30, 2023

Change Summary

When installing the new Endpoint package with the 8.7.0 changes, the addition of a type u64 is causing the package to fail to install. This changes this to be unsigned_long which is a supported type and can be installed.

The merge that introduced the unsupported type was only applied to the 8.7.0 line, so we just need to fix it here before releasing the new package. The problem has not been released to production.

PR with the u64 type: #329

Console error with u64 type:
image

new installed template with unsigned_long
image

Sample values

Sample document:

Release Target

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes
  • If these field(s) are "exception"-able, I made a companion PR to Kibana adding it (see Readme)
  • If this is a metadata change, I also updated both transform destination schemas to match

For Transform changes:

  • The new transform successfully starts in Kibana
  • The corresponding transform destination schema was updated if necessary

@kevinlog kevinlog requested a review from a team as a code owner January 30, 2023 20:37
@kevinlog kevinlog changed the title Update unsupported u64 type to long Update unsupported u64 type to unsigned_long Jan 30, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-30T20:45:15.367+0000

  • Duration: 8 min 19 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kevinlog kevinlog merged commit fd6ffbc into main Jan 31, 2023
@kevinlog kevinlog deleted the task/update-unsupported-type-u64-to-long branch January 31, 2023 21:34
@elasticmachine
Copy link
Contributor

Package endpoint - 8.7.0 containing this change is available at https://epr.elastic.co/search?package=endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants