-
Notifications
You must be signed in to change notification settings - Fork 19
[8.18/9.0]Change the size of region_start_bytes + add the field to the alert data stream #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @pzl I assume this is because we changed the size of |
what is the version number of the defend integration you have installed? On the fleet integrations page, is the "install beta integrations" button enabled? |
Hi @pzl |
@AsuNa-jp unclear, perhaps an issue where documents were indexed before the mapping was created. Old documents will not be reindexed automatically. And kibana's discover may have an outdated heuristic about that field now. Try with a clean install, where the integration is up-to-date and the mapping exists before ingesting the documents |
@pzl (CC: @magermark ) After comparing Kibana before and after emitting events that include fields
To be honest, I’m not sure about the cause and wonder if it might be a bug on Kibana’s side. If there’s someone more suitable to ask, I’d be happy to reach out to them. Do you have any thoughts or know someone who might? |
hi @pzl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AsuNa-jp please update the file package/endpoint/data_stream/alerts/sample_event.json
to place an example value of this field where it would appear. This will aid in some automated testing for this field addition within the repo here
otherwise, all good to go 👍
…-package into region_start_bytes_size
@pzl
|
…e alert data stream (#591) * change the size of region_start_bytes * add generated files * add field to memory protection event * add generated files * add sample * fix format * format fix * fix
…e alert data stream (#591) * change the size of region_start_bytes * add generated files * add field to memory protection event * add generated files * add sample * fix format * format fix * fix
…he alert data stream (#591) (#598) * change the size of region_start_bytes * add generated files * add field to memory protection event * add generated files * add sample * fix format * format fix * fix Co-authored-by: Asuka Nakajima <[email protected]>
…he alert data stream (#591) (#599) * change the size of region_start_bytes * add generated files * add field to memory protection event * add generated files * add sample * fix format * format fix * fix Co-authored-by: Asuka Nakajima <[email protected]>
…e alert data stream (#591) * change the size of region_start_bytes * add generated files * add field to memory protection event * add generated files * add sample * fix format * format fix * fix
…ta stream (#591) (#603) * change the size of region_start_bytes * add generated files * add field to memory protection event * add generated files * add sample * fix format * format fix * fix Co-authored-by: Asuka Nakajima <[email protected]>
Change Summary
We changed the size (string size) of the following fields from 32 bytes to 64 bytes. Thus, we would like to change the discription and example written in the endpoint-package as well. Moreover, this PR add the fields to the alert data stream.
The field itself was added at this PR.
Sample values
Sample document:
Release Target
8.18/9.0
Q/A
For mapping changes:
make
after making the schema changes, and committed all changes