Skip to content

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 15, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bugfix Pull request that fixes a bug issue Integration:amazon_security_lake Amazon Security Lake Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 15, 2024
@efd6 efd6 self-assigned this Aug 15, 2024
@efd6 efd6 force-pushed the s5047-amazon_security_lake branch from a8ae430 to c9cd8b5 Compare August 15, 2024 05:27
@efd6 efd6 force-pushed the s5047-amazon_security_lake branch from c9cd8b5 to 90395cf Compare August 15, 2024 05:33
@elasticmachine
Copy link

🚀 Benchmarks report

Package amazon_security_lake 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 397.61 277.78 -119.83 (-30.14%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

Copy link

@efd6 efd6 marked this pull request as ready for review August 15, 2024 06:19
@efd6 efd6 requested a review from a team as a code owner August 15, 2024 06:19
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit e9bd635 into elastic:main Aug 15, 2024
@elasticmachine
Copy link

Package amazon_security_lake - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=amazon_security_lake

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@efd6 efd6 deleted the s5047-amazon_security_lake branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:amazon_security_lake Amazon Security Lake Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants