Skip to content

[snort] Fix time format using incorrect year specifier #12599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2025
Merged

[snort] Fix time format using incorrect year specifier #12599

merged 3 commits into from
Feb 4, 2025

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Feb 4, 2025 •
edited
Loading

Proposed commit message

  • The time format used "week-based-year" (Y) instead of "year-of-era" (y). The former gives very different results when calculating the month and date, since it is week-based.
  • Regenerated test files with updated dates.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/snort
elastic-package test

Related issues

@taylor-swanson taylor-swanson added Integration:snort Snort bugfix Pull request that fixes a bug issue Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Feb 4, 2025
@taylor-swanson taylor-swanson self-assigned this Feb 4, 2025
@taylor-swanson taylor-swanson mentioned this pull request Feb 4, 2025
Merged
4 tasks
@taylor-swanson taylor-swanson marked this pull request as ready for review February 4, 2025 17:28
@taylor-swanson taylor-swanson requested a review from a team as a code owner February 4, 2025 17:28
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@qcorporation qcorporation requested review from a team as code owners February 4, 2025 18:34
@taylor-swanson
[snort] Fix time format using incorrect year specifier
d826c76 
- The time format used "week-based-year" (Y) instead of "year-of-era" (y). The former
gives very different results when calculating the month and date, since it is week-based.
- Regenerated test files with updated dates.
@taylor-swanson
changelog
63b59af
@taylor-swanson taylor-swanson removed request for a team February 4, 2025 20:27
@taylor-swanson taylor-swanson enabled auto-merge (squash) February 4, 2025 21:37
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson taylor-swanson merged commit 67cbd45 into elastic:main Feb 4, 2025
3 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@taylor-swanson taylor-swanson deleted the fix/snort-time-format branch February 4, 2025 22:01
@elastic-vault-github-plugin-prod
Copy link

Package snort - 1.16.1 containing this change is available at https://epr.elastic.co/package/snort/1.16.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwhyrock dwhyrock dwhyrock approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels

bugfix Pull request that fixes a bug issue Integration:snort Snort Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[snort] Change in expected @timestamp when running tests at newer stack versions

3 participants

@taylor-swanson @elasticmachine @dwhyrock