-
Notifications
You must be signed in to change notification settings - Fork 497
Add support for Azure Spring Cloud logs #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
@sorantis , @hemantmalik , I have added the logs format and dashboards in the description, let me know what you think |
Hey, @narph those are looking great. Thank you for sharing the update. |
type: keyword | ||
- name: ecs.version | ||
external: ecs | ||
description: ECS version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you load an external field, you don't need to add descriptions here (I'm not sure if we have overriding feature implemented).
external: ecs | ||
- name: event | ||
external: ecs | ||
- name: host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to mention all leaf-fields not just groups. We don't want to import definitions for all fields behind host, but just ones that are actually used. Unfortunately the tool can't figure it out on it's own.
@@ -1,249 +1,28 @@ | |||
- description: IP address of the client. | |||
name: client.ip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fields defining client
family is here: https://github.com/elastic/ecs/blob/master/generated/beats/fields.ecs.yml#L147
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment about the ecs.yml
file. Otherwise it LGTM, please wait for the CI status.
@@ -0,0 +1,27 @@ | |||
- name: ecs.version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you don't need this file now.
PR description will be updated soon
What does this PR do?
Add support for Azure Spring Cloud logs
Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Author's Checklist
How to test this PR locally
Related issues
Example:
Screenshots