Skip to content

Security Integrations: Add Deprecation Note in Readme #14105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2025
Merged

Security Integrations: Add Deprecation Note in Readme #14105

merged 3 commits into from
Jun 9, 2025

Conversation

mohitjha-elastic
Copy link
Collaborator

@mohitjha-elastic mohitjha-elastic commented Jun 2, 2025 •
edited
Loading

Proposed Commit Message

bluecoat, cloud_defend, cylance, fortinet_forticlient, juniper_junos, juniper_netscreen, netscout, 
radware, tomcat: deprecate package and add deprecation note in readme

* cloud_defend, cylance, tomcat: deprecate the package and add note in readme that the package is not
supported for installation in Elastic Cloud Serverless.
* bluecoat, fortinet_forticlient, juniper_junos, juniper_netscreen, netscout, 
radware : Add deprecation note in readme that the package is not supported for installation in
Elastic Cloud Serverless.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Clone integrations repo.
Install the elastic package locally.
Start the elastic stack using the elastic package.
Move to integrations/packages/<integration_name> directory.
Run the following command to run tests.
elastic-package test -v

Replace the <integration_name> with the actual integration name.

Related issues

@mohitjha-elastic mohitjha-elastic self-assigned this Jun 2, 2025
@mohitjha-elastic mohitjha-elastic requested review from a team as code owners June 2, 2025 10:29
@mohitjha-elastic mohitjha-elastic added enhancement New feature or request deprecation Integration:cylance CylanceProtect Logs (Deprecated) Integration:netscout Arbor Peakflow SP Logs (Deprecated) Integration:bluecoat Blue Coat Director Logs (Deprecated) Integration:radware Radware DefensePro Logs (Deprecated) Integration:cloud_defend Defend for Containers (Deprecated) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:juniper_junos Juniper JunOS (Deprecated) Integration:juniper_netscreen Juniper NetScreen (Deprecated) Integration:fortinet_forticlient Fortinet FortiClient Logs (Deprecated) Integration:tomcat Tomcat NetWitness Logs (Deprecated) Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Jun 2, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@mohitjha-elastic mohitjha-elastic force-pushed the add-deprecate-label-in-readme branch from 59a96c6 to e4e49d1 Compare June 2, 2025 10:38
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jun 2, 2025 •
edited
Loading

🚀 Benchmarks report

Package bluecoat 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
director 28571.43 17857.14 -10714.29 (-37.5%) 💔

Package tomcat 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 90909.09 58823.53 -32085.56 (-35.29%) 💔

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Jun 2, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

ishleenk17
ishleenk17 reviewed Jun 9, 2025
View reviewed changes
packages/tomcat/_dev/build/docs/README.md Outdated
>
> This package is *deprecated* and is not supported for installation in Elastic Cloud Serverless.
# Tomcat NetWitness Logs integration (To be deprecated soon)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are adding this in README.
Lets change "To be deprecated soon" to DEPRECATED

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @mohitjha-elastic

@mohitjha-elastic
Resolve review comments.
20a5b1a 
Update readme. Add deprecated label in tomcat readme file.
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mohitjha-elastic

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@kcreddy kcreddy merged commit 161f3f1 into elastic:main Jun 9, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package bluecoat - 0.18.0 containing this change is available at https://epr.elastic.co/package/bluecoat/0.18.0/

@elastic-vault-github-plugin-prod
Copy link

Package cloud_defend - 1.3.0 containing this change is available at https://epr.elastic.co/package/cloud_defend/1.3.0/

@elastic-vault-github-plugin-prod
Copy link

Package cylance - 0.24.0 containing this change is available at https://epr.elastic.co/package/cylance/0.24.0/

@elastic-vault-github-plugin-prod
Copy link

Package fortinet_forticlient - 1.12.0 containing this change is available at https://epr.elastic.co/package/fortinet_forticlient/1.12.0/

@elastic-vault-github-plugin-prod
Copy link

Package juniper_junos - 0.11.0 containing this change is available at https://epr.elastic.co/package/juniper_junos/0.11.0/

@elastic-vault-github-plugin-prod
Copy link

Package juniper_netscreen - 0.11.0 containing this change is available at https://epr.elastic.co/package/juniper_netscreen/0.11.0/

@elastic-vault-github-plugin-prod
Copy link

Package netscout - 0.21.0 containing this change is available at https://epr.elastic.co/package/netscout/0.21.0/

@elastic-vault-github-plugin-prod
Copy link

Package radware - 0.20.0 containing this change is available at https://epr.elastic.co/package/radware/0.20.0/

@elastic-vault-github-plugin-prod
Copy link

Package tomcat - 1.13.0 containing this change is available at https://epr.elastic.co/package/tomcat/1.13.0/

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy left review comments

@chrisberkhout chrisberkhout chrisberkhout approved these changes

@nfritts nfritts nfritts approved these changes

@taylor-swanson taylor-swanson taylor-swanson approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees

@mohitjha-elastic mohitjha-elastic

Labels

deprecation documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:bluecoat Blue Coat Director Logs (Deprecated) Integration:cloud_defend Defend for Containers (Deprecated) Integration:cylance CylanceProtect Logs (Deprecated) Integration:fortinet_forticlient Fortinet FortiClient Logs (Deprecated) Integration:juniper_junos Juniper JunOS (Deprecated) Integration:juniper_netscreen Juniper NetScreen (Deprecated) Integration:netscout Arbor Peakflow SP Logs (Deprecated) Integration:radware Radware DefensePro Logs (Deprecated) Integration:tomcat Tomcat NetWitness Logs (Deprecated) Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add comment in the README for non-deprecated integrations that are not supported in serverless

8 participants

@mohitjha-elastic @elasticmachine @chrisberkhout @kcreddy @nfritts @taylor-swanson @ishleenk17 @andrewkroh