Skip to content

Add Proxy configs for httpjson, aws-s3 inputs and AWS metric sets #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2021
Merged

Add Proxy configs for httpjson, aws-s3 inputs and AWS metric sets #1648

merged 2 commits into from
Sep 14, 2021

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Sep 13, 2021 •
edited
Loading

What does this PR do?

Add Proxy config option for packages with the httpjson, aws-s3 inputs and AWS metric sets

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

image

@elasticmachine
Copy link

elasticmachine commented Sep 13, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-14T09:50:06.216+0000

  • Duration: 19 min 38 sec

  • Commit: 8c1f36a

Test stats 🧪

Test Results
Failed 0
Passed 391
Skipped 0
Total 391

Trends 🧪

Image of Build Times

Image of Tests

@legoguy1000 legoguy1000 marked this pull request as ready for review September 13, 2021 01:14
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh added Integration:aws AWS Integration:crowdstrike CrowdStrike Integration:Microsoft (Deprecated) Use of the specific microsoft_X labels. [Integration not found in source] Integration:okta Okta Integration:system System labels Sep 13, 2021
@andrewkroh
Copy link
Member

run tests

@andrewkroh andrewkroh added the Integration:cloudflare Cloudflare (Community supported) label Sep 13, 2021
@legoguy1000
Copy link
Contributor Author

@andrewkroh fixed the formatting errors caught by CI.

@P1llus
Copy link
Member

P1llus commented Sep 14, 2021

/test

@P1llus
Copy link
Member

P1llus commented Sep 14, 2021

@kaiyan-sheng Could you approve this as well?

@P1llus P1llus added the Team:Integrations Label for the Integrations team label Sep 14, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@kaiyan-sheng
Copy link
Contributor

Thanks for the PR. This PR is to sync elastic/beats#26832 into integrations.

@P1llus P1llus merged commit 45266ac into elastic:master Sep 14, 2021
@legoguy1000 legoguy1000 deleted the 1647-proxy-url branch September 14, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P1llus P1llus P1llus approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

No one assigned

Labels

Integration:aws AWS Integration:cloudflare Cloudflare (Community supported) Integration:crowdstrike CrowdStrike Integration:Microsoft (Deprecated) Use of the specific microsoft_X labels. [Integration not found in source] Integration:okta Okta Integration:system System Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legoguy1000 @elasticmachine @andrewkroh @P1llus @kaiyan-sheng