Skip to content

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Jun 7, 2022

What does this PR do?

Updates the package names with standard wording

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine
Copy link

elasticmachine commented Jun 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-18T17:09:29.628+0000

  • Duration: 78 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 1264
Skipped 1
Total 1265

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 7, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (107/107) 💚
Files 96.729% (207/214) 👎 -0.351
Classes 96.729% (207/214) 👎 -0.351
Methods 91.751% (1813/1976) 👍 2.205
Lines 91.79% (31987/34848) 👍 1.925
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy marked this pull request as ready for review June 8, 2022 06:14
@kcreddy kcreddy requested a review from a team as a code owner June 8, 2022 06:14
@jamiehynds
Copy link

Thanks for working through these changes @kcreddy. The only one I'm wary of is the httpjson input - I've pinged Serena from the Enterprise Search team, to see if we can come up with a better option. They already have a Custom API integration but hoping we can align on naming.

@kcreddy kcreddy changed the title Standardised names for security integrations Standardised names and descriptions for security integrations Jun 16, 2022
@kcreddy kcreddy requested a review from adriansr July 11, 2022 10:29
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Azure logs part LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Security Integration Names

8 participants