[Enhancement] [AWS Security Hub] Update the Pagination Termination Condition

[vinit-chauhan]

Type of change

• Enhancement

What does this PR do?

Update the Pagination Termination Condition for AWS Security Hub connector.

Current condition for pagination termination contains [[else]][[.last_response.terminate_pagination]][[end]] which results in error logs when pagination is completed.

Removing this else condition will not result in error logs.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

• Clone integrations repo.
• Install elastic package locally.
• Start elastic stack using elastic-package.
• Move to integrations/packages/aws directory.
• Run the following command to run tests.

elastic-package test

Related issues

• Relates Update the pagination termination condition in security connectors #4527

Screenshots

[elasticmachine]

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

[elasticmachine]

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-11-23T10:47:06.204+0000

• Duration: 37 min 39 sec

Test stats 🧪

Test	Results
Failed	0
Passed	177
Skipped	3
Total	180

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (14/14)	💚
Files	93.333% (14/15)	❕
Classes	93.333% (14/15)	❕
Methods	85.098% (217/255)	❕
Lines	95.949% (5897/6146)	❕
Conditionals	100.0% (0/0)	💚

[P1llus]

Need a minor fix @vinit-elastic , then I can merge it

[P1llus]

You are linting all the yml files for all the data_streams here, please remove it

[vinit-chauhan]

Hey @P1llus, There is one pull request that has been merged in main that removes the last line of all agent.yml files. As a result, we must include the final line in all files; otherwise, the elastic-package check will fail.

[P1llus]

Double checked with @kaiyan-sheng on the changes to agent.yml, it was indeed necessary, so we will go ahead and merge.

[elasticmachine]

Package aws - 1.27.2 containing this change is available at https://epr.elastic.co/search?package=aws