-
Notifications
You must be signed in to change notification settings - Fork 497
[AWS] Support VPC flow logs with message field #4830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kaiyan-sheng
merged 5 commits into
elastic:main
from
kaiyan-sheng:scrape_message_field_vpcflow
Dec 15, 2022
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1b0a2dc
Support VPC flow logs with message field
kaiyan-sheng 3631a33
add changelog
kaiyan-sheng a4570ab
Add dot_expander processor to expand all fields with dot into object …
kaiyan-sheng e2af9cc
update changelog
kaiyan-sheng 23edb46
add quote
kaiyan-sheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
packages/aws/data_stream/vpcflow/_dev/test/pipeline/test-with-message-field.log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{\"message\":\"2 428961148399 eni-0e0bf7be352692297 - - - - - - - 1671029698 1671029728 - NODATA\"} | ||
35 changes: 35 additions & 0 deletions
35
...ages/aws/data_stream/vpcflow/_dev/test/pipeline/test-with-message-field.log-expected.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
{ | ||
"expected": [ | ||
{ | ||
"@timestamp": "2022-12-14T14:55:28.000Z", | ||
"aws": { | ||
"vpcflow": { | ||
"account_id": "428961148399", | ||
"interface_id": "eni-0e0bf7be352692297", | ||
"log_status": "NODATA", | ||
"version": "2" | ||
} | ||
}, | ||
"cloud": { | ||
"account": { | ||
"id": "428961148399" | ||
}, | ||
"provider": "aws" | ||
}, | ||
"ecs": { | ||
"version": "8.0.0" | ||
}, | ||
"event": { | ||
"category": "network", | ||
"end": "2022-12-14T14:55:28.000Z", | ||
"kind": "event", | ||
"original": "2 428961148399 eni-0e0bf7be352692297 - - - - - - - 1671029698 1671029728 - NODATA", | ||
"start": "2022-12-14T14:54:58.000Z", | ||
"type": "connection" | ||
}, | ||
"tags": [ | ||
"preserve_original_event" | ||
] | ||
} | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test case is efficient, I don't think the nested message level actually happens hmmm
The events look like this when VPC flow logs are sent directly without going through CloudWatch.