Skip to content

[Ceph] Add Integration Package with OSD Tree data stream #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2023
Merged

[Ceph] Add Integration Package with OSD Tree data stream #5174

merged 4 commits into from
Feb 7, 2023

Conversation

harnish-crest-data
Copy link
Contributor

@harnish-crest-data harnish-crest-data commented Feb 2, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Added 1 data stream (OSD Tree metrics).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/ceph directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

@kush-elastic kush-elastic self-requested a review February 2, 2023 12:56
@kush-elastic kush-elastic added enhancement New feature or request Integration:ceph Ceph Team:Service-Integrations Label for the Observability Service Integrations team labels Feb 2, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 2, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-07T12:45:06.799+0000

  • Duration: 16 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 21
Skipped 0
Total 21

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic
Copy link
Contributor

/test

@harnish-crest-data harnish-crest-data marked this pull request as ready for review February 2, 2023 13:10
@elasticmachine
Copy link

elasticmachine commented Feb 2, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 6.25
Classes 100.0% (4/4) 💚 6.25
Methods 100.0% (33/33) 💚 13.869
Lines 92.308% (240/260) 👍 6.382
Conditionals 100.0% (0/0) 💚

This was referenced Feb 2, 2023
Merged
Merged
Merged
Merged
Merged
kush-elastic
kush-elastic approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved

agithomas
agithomas reviewed Feb 4, 2023
View reviewed changes
packages/ceph/data_stream/osd_tree/fields/fields.yml Outdated
- name: exists
type: boolean
description: Represent OSD node still exist or not (1-true, 0-false).
- name: id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this to osd_id or node_id which ever is most appropriate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field contains both osd_id as well as node_id. We can change it to node_osd_id. Please let me know your suggestions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go with node_osd_id

packages/ceph/data_stream/osd_tree/fields/fields.yml Outdated
- name: id
type: long
description: OSD or bucket node id.
- name: name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this to osd_name or node_name whichever is most appropriate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field contains both osd_name as well as node_name. We can change it to node_osd_name. Please let me know your suggestions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go with node_osd_name

agithomas
agithomas approved these changes Feb 6, 2023
View reviewed changes
packages/ceph/data_stream/osd_tree/fields/fields.yml Outdated
- name: exists
type: boolean
description: Represent OSD node still exist or not (1-true, 0-false).
- name: id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go with node_osd_id

packages/ceph/data_stream/osd_tree/fields/fields.yml Outdated
- name: id
type: long
description: OSD or bucket node id.
- name: name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go with node_osd_name

@harnish-crest-data harnish-crest-data requested a review from a team as a code owner February 7, 2023 12:35
@kush-elastic kush-elastic merged commit 60058ec into elastic:main Feb 7, 2023
@elasticmachine
Copy link

Package ceph - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=ceph

This was referenced Feb 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

@SubhrataK SubhrataK Awaiting requested review from SubhrataK

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harnish-crest-data harnish-crest-data

Labels

enhancement New feature or request Integration:ceph Ceph Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harnish-crest-data @elasticmachine @kush-elastic @agithomas