Skip to content

Conversation

tdancheva
Copy link
Contributor

@tdancheva tdancheva commented Jun 7, 2023

What does this PR do?

This PR migrates the "[Logs Azure] Cloud Overview" dashboard to Lens, changes the style of the metrics, and makes changes to the filters in accordance with the new dashboard design guidelines.

Fixed the alerts and service health visualizations that were not getting populated due to the event_category field not showing the proper category, instead the category field is populated. See this PR for more info.

NOTE: The after screenshot is taken with stack version 8.6.2. Panel titles of Lens Metrics type do not show in version 8.6.x, from 8.7.0 they show correctly. I will bump up the minimum Kibana version in the whole package in a separate PR that I will link here as well.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Before:

ClOUD_OVERVIEW_BEFORE_3

After:
AFTER

After fixing N/A:

Screenshot 2023-06-08 at 10 21 16

@tdancheva tdancheva added the enhancement New feature or request label Jun 7, 2023
@elasticmachine
Copy link

elasticmachine commented Jun 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T15:32:47.228+0000

  • Duration: 14 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👍
Classes 86.364% (19/22) 👍
Methods 83.333% (155/186) 👍
Lines 84.935% (2802/3299) 👍
Conditionals 100.0% (0/0) 💚

@tdancheva tdancheva marked this pull request as ready for review June 7, 2023 14:59
@tdancheva tdancheva requested a review from a team as a code owner June 7, 2023 14:59
@zmoog zmoog requested a review from a team June 8, 2023 09:40
@drewdaemon
Copy link
Contributor

drewdaemon commented Jun 8, 2023

Thanks for doing this! A couple initial recommendations:

I see that we are currently using dynamic coloring with the "status" palette for the activity stats and top users:

Screenshot 2023-06-08 at 4 34 38 PM

I'm not sure this coloring is a good fit since these are valence-free numbers (it isn't necessarily a bad or a good thing to have a higher or lower resource count, for example).

  • For the activity stats, I would recommend changing the background color of those metrics to a static white.

  • For the top users, I would recommend we use a horizontal bar chart as we do with the "top resource groups." We could also wait for the release of Kibana 8.9 when Tag cloud will be available in Lens.

Let me know if this makes sense

@tdancheva
Copy link
Contributor Author

Thanks for doing this! A couple initial recommendations:

I see that we are currently using dynamic coloring with the "status" palette for the activity stats and top users:

Screenshot 2023-06-08 at 4 34 38 PM I'm not sure this coloring is a good fit since these are valence-free numbers (it isn't necessarily a bad or a good thing to have a higher or lower resource count, for example).
  • For the activity stats, I would recommend changing the background color of those metrics to a static white.
  • For the top users, I would recommend we use a horizontal bar chart as we do with the "top resource groups." We could also wait for the release of Kibana 8.9 when Tag cloud will be available in Lens.

Let me know if this makes sense

Yes, it does, thanks a lot for the feedback! Here is the updated dashboard. I also changed resource groups to Pie plot since it seems more readable to me that way, but let me know If you think otherwise.

AFTER_REVIEW_4

@drewdaemon
Copy link
Contributor

drewdaemon commented Jun 12, 2023

@tdancheva

Thanks for making those changes.

I also changed resource groups to Pie plot since it seems more readable to me that way, but let me know If you think otherwise.

I'll start by asking you: which of the following would be most helpful to the user?

  1. Seeing how the set of all their resource groups breaks down into subcategories
  2. Seeing the top N most-used resource types

These are related but different.

If 1., then I think a partition chart such as a donut makes sense, but I would advise you to increase the number of terms to a large-enough number to be relatively sure that all the group types will be shown (100 or so?). Otherwise, the partition chart will imply that all the group types are shown but they won't be. (Side-note: you might try a treemap chart here for better use of the space).

I would also rename the panel to something like "Resource group breakdown," or simply "Resource groups" since it should no longer be just the top ones.

If 2., I think something like the original bar chart is a better fit and we could look into why you didn't find it readable.

@drewdaemon
Copy link
Contributor

Ah, one other point

Can we switch the color palettes for the visualizations to the system default?

Old palette:
Screenshot 2023-03-30 at 4 37 09 PM

Default palette
Screenshot 2023-03-30 at 4 37 24 PM

@tdancheva
Copy link
Contributor Author

tdancheva commented Jun 13, 2023

@tdancheva

Thanks for making those changes.

I also changed resource groups to Pie plot since it seems more readable to me that way, but let me know If you think otherwise.

I'll start by asking you: which of the following would be most helpful to the user?

  1. Seeing how the set of all their resource groups breaks down into subcategories
  2. Seeing the top N most-used resource types

These are related but different.

If 1., then I think a partition chart such as a donut makes sense, but I would advise you to increase the number of terms to a large-enough number to be relatively sure that all the group types will be shown (100 or so?). Otherwise, the partition chart will imply that all the group types are shown but they won't be. (Side-note: you might try a treemap chart here for better use of the space).

I would also rename the panel to something like "Resource group breakdown," or simply "Resource groups" since it should no longer be just the top ones.

If 2., I think something like the original bar chart is a better fit and we could look into why you didn't find it readable.

Thank you so much for the insight @drewdaemon. You are right, it is case 2) I believe. I changed it back and I also addressed your other comment about the color palette and changed them to default.

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@tdancheva tdancheva merged commit 035ab82 into elastic:main Jun 20, 2023
@elasticmachine
Copy link

Package azure - 1.5.22 containing this change is available at https://epr.elastic.co/search?package=azure

@andrewkroh andrewkroh added the Integration:azure Azure Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:azure Azure Logs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants