Skip to content

[atlassian_confluence] Ensure pagination request parameters are properly encoded #7802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2023
Merged

[atlassian_confluence] Ensure pagination request parameters are properly encoded #7802

merged 3 commits into from
Sep 18, 2023

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Sep 13, 2023 •
edited
Loading

What does this PR do?

  • Set pagination parameters via set transforms, which will also ensure that the parameters are properly encoded
  • Add hit count asserts for system tests
  • Add regex validation to system tests

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package test

Related issues

@taylor-swanson
[atlassian_confluence] Ensure pagination request parameters are prope…
3921279 
…rly encoded

- Set pagination parameters via set transforms, which will also ensure that
the parameters are properly encoded
- Add hit count asserts for system tests
- Add regex validation to system tests
@taylor-swanson taylor-swanson added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:atlassian_confluence Atlassian Confluence (Community supported) labels Sep 13, 2023
@taylor-swanson taylor-swanson self-assigned this Sep 13, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 13, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-14T13:08:25.528+0000

  • Duration: 15 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 13, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (24/24) 💚 75.0
Lines 98.789% (408/413) 👎 -1.211
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review September 13, 2023 17:26
@taylor-swanson taylor-swanson requested a review from a team as a code owner September 13, 2023 17:26
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@taylor-swanson taylor-swanson merged commit e0a13b3 into elastic:main Sep 18, 2023
@taylor-swanson taylor-swanson deleted the issue/7761-confluence-encoding branch September 18, 2023 12:37
@elasticmachine
Copy link

Package atlassian_confluence - 1.16.2 containing this change is available at https://epr.elastic.co/search?package=atlassian_confluence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels

bug Something isn't working, use only for issues Integration:atlassian_confluence Atlassian Confluence (Community supported)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[atlassian_confluence] Pagination URL parameters are not properly escaped

3 participants

@taylor-swanson @elasticmachine @efd6