Skip to content

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 22, 2023

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:trendmicro Trend Micro Deep Security labels Nov 22, 2023
@efd6 efd6 self-assigned this Nov 22, 2023
@efd6 efd6 force-pushed the e20244-trendmicro branch from f816986 to e2a6919 Compare November 22, 2023 20:54
@elasticmachine
Copy link

elasticmachine commented Nov 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-24T07:06:34.642+0000

  • Duration: 17 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 22.222% (2/9) 👎 -72.222
Classes 22.222% (2/9) 👎 -72.222
Methods 33.333% (14/42) 👎 -56.368
Lines 23.007% (101/439) 👎 -63.076
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 22, 2023 21:43
@efd6 efd6 requested a review from a team as a code owner November 22, 2023 21:43
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
Could add assert.hit_count to system test configurations.

@efd6 efd6 merged commit b291bbc into elastic:main Nov 24, 2023
@elasticmachine
Copy link

Package trendmicro - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=trendmicro

@efd6 efd6 deleted the e20244-trendmicro branch February 5, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:trendmicro Trend Micro Deep Security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants