Use ingest node as much as possible for CEF integrations #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
enhancement
2 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Move as much processing as possible into the Ingest Node pipeline. The Beat's decode_cef processor must still be used since there isn't a replacement in Ingest Node. This moves away from the Beats syslog input and relies on ingest node to handle parsing. This allows the original syslog message to be kept with the event.original field. And it avoids the non-ECS fields of the syslog input. One improvement is that if syslog data is read from a file then this will now extract the syslog timestamp in the Ingest Node pipeline. Previously only data from the syslog input got this treatment because the timestamp was parsed by the input. The grok pattern that read the timestamp can accept both RFC 3164 or RFC 5424 formats (it only grabs the timestamp and syslog priority). Closes #656
marc-gr
reviewed
Apr 8, 2021
marc-gr
approved these changes
Apr 8, 2021
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move as much processing as possible into the Ingest Node pipeline. The Beat's decode_cef processor must still be used since there isn't a replacement in Ingest Node. Closes #656
This moves away from the Beats syslog input and relies on ingest node to handle parsing. This allows the original syslog message to be kept with the event.original field. And it avoids the non-ECS fields of the syslog input.
One improvement is that if syslog data is read from a file then this will now extract the syslog timestamp in the Ingest Node pipeline. Previously only data from the syslog input got this treatment because the timestamp was parsed by the input. The grok pattern that read the timestamp can accept both RFC 3164 or RFC 5424 formats (it only grabs the timestamp and syslog priority).
Checklist
changelog.ymlfile.Related issues