-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[CoreRenderingService] Add dev docs #218630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreRenderingService] Add dev docs #218630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text lgtm, haven't previewed
- `KibanaRootContextProvider` - A root context provider for Kibana. This is the top level context provider that wraps the entire application. It is responsible for initializing all of the other contexts and providing them to the application. | ||
- `KibanaRenderContextProvider` - A render context provider for Kibana. This context is designed to be used with ad-hoc renders of React components, (usually with `ReactDOM.render`). | ||
- `KibanaThemeContextProvider` - A theme context provider for Kibana. A corollary to EUI's `EuiThemeProvider`, it uses Kibana services to ensure the EUI Theme is customized correctly. | ||
- <DocLink id="react/context/root" text="`KibanaRootContextProvider`" /> - A root context provider for Kibana. This is the top level context provider that wraps the entire application. It is responsible for initializing all of the other contexts and providing them to the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, haven't checked if the links work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for adding these dev docs. Left some nit edits.
Bonus nit: would be nice to have a screenshot of the docs in the PR desciption.
Co-authored-by: Anton Dosov <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>
💚 Build Succeeded
Metrics [docs]
History
|
A documentation structure update was unintentionally missed in #218630 This update promotes the Core Rendering Service and offsets the prior documentation of Kibana React Contexts. ## Summary <img width="1800" alt="image" src="https://github.com/%3Ca%20href="https://github.com/user-attachments/assets/9c7634c9-2a1e-43d8-8bb7-850bbf96fc53">https://github.com/user-attachments/assets/9c7634c9-2a1e-43d8-8bb7-850bbf96fc53" />
## Summary Epic: elastic/kibana-team#1435 New Dev Docs for Core Rendering Service <img width="902" alt="image" src="https://github.com/%3Ca%20href="https://github.com/user-attachments/assets/aa1b8bdb-751d-4ab1-a0e1-8bf62c1c8d96">https://github.com/user-attachments/assets/aa1b8bdb-751d-4ab1-a0e1-8bf62c1c8d96" /> --------- Co-authored-by: Anton Dosov <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>
A documentation structure update was unintentionally missed in elastic#218630 This update promotes the Core Rendering Service and offsets the prior documentation of Kibana React Contexts. ## Summary <img width="1800" alt="image" src="https://github.com/%3Ca%20href="https://github.com/user-attachments/assets/9c7634c9-2a1e-43d8-8bb7-850bbf96fc53">https://github.com/user-attachments/assets/9c7634c9-2a1e-43d8-8bb7-850bbf96fc53" />
A documentation structure update was unintentionally missed in elastic#218630 This update promotes the Core Rendering Service and offsets the prior documentation of Kibana React Contexts. ## Summary <img width="1800" alt="image" src="https://github.com/%3Ca%20href="https://github.com/user-attachments/assets/9c7634c9-2a1e-43d8-8bb7-850bbf96fc53">https://github.com/user-attachments/assets/9c7634c9-2a1e-43d8-8bb7-850bbf96fc53" />
Summary
Epic: https://github.com/elastic/kibana-team/issues/1435
New Dev Docs for Core Rendering Service
