This repository was archived by the owner on Dec 5, 2022. It is now read-only.
Update packaging script to match electron-packager breaking changes #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @jbleuzen. This looks strange though: Sure you got that right? |
|
cc @malept 👀 |
|
See the remove section : |
|
Ah I see it here: https://github.com/electron-userland/electron-packager/blob/5bbbf03b5887bc25939b50858122d0df30d868c0/NEWS.md#removed It looks like |
|
There is also this line explaining that you must not combine both |
malept
reviewed
Oct 13, 2016
| "pack-linux": "electron-packager . --asar --asar-unpack=protocol-link.html --overwrite --platform=linux --arch=x64 --icon=assets/app-icon/png/64.png --prune=true --out=out", | ||
| "pack-mac": "electron-packager . --asar.unpack=protocol-link.html --overwrite --platform=darwin --arch=x64 --icon=assets/app-icon/mac/app.icns --prune=true --out=out --osx-sign.identity='Developer ID Application: GitHub' --extend-info=assets/mac/info.plist", | ||
| "pack-win": "electron-packager . ElectronAPIDemos --asar.unpack=protocol-link.html --overwrite --platform=win32 --arch=ia32 --icon=assets/app-icon/win/app.ico --prune=true --out=out --version-string.CompanyName='GitHub, Inc.' --version-string.FileDescription='Electron API Demos' --version-string.ProductName='Electron API Demos'", | ||
| "pack-linux": "electron-packager . --asar.unpack=protocol-link.html --overwrite --platform=linux --arch=x64 --icon=assets/app-icon/png/64.png --prune=true --out=out", |
There was a problem hiding this comment.
--icon is not necessary for Linux, see API docs for icon
Huh? |
|
Oops I wasn't looking at latest master. Sorry for the confusion and thanks for the fix, @jbleuzen |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With version 8.0.0 of electron-packager asar options changed and you don't need --asar when you are using --asar.unpack.
This fix the behaviour of the "View demo" button on Protocol Handler demo.