cnn: Fix hardcoded outputs size leading to corrupted predictions #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would give corrupt results for anything else than outputs with 10 lenght
The .run() function now requires an array.array('f') where to place output
There is a new method, output_dimensions() to get the shape of the output
The layer_cb of tm_load is not called at load time, only at tm_run() time
jonnor
commented
Dec 18, 2024
| int maxi = -1; | ||
|
|
||
| // TODO: pass the entire output vector out to Python | ||
| // FIXME: unhardcode output handling |
There was a problem hiding this comment.
Fixing the FIXMEs are a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.