Skip to content

cnn: Fix hardcoded outputs size leading to corrupted predictions #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

jonnor
Copy link
Contributor

@jonnor jonnor commented Dec 18, 2024

No description provided.

Would give corrupt results for anything else than outputs with 10 lenght
The .run() function now requires an array.array('f') where to place output
There is a new method, output_dimensions() to get the shape of the output
The layer_cb of tm_load is not called at load time, only at tm_run() time
int maxi = -1;

// TODO: pass the entire output vector out to Python
// FIXME: unhardcode output handling
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the FIXMEs are a good idea

@jonnor jonnor merged commit 05c25cb into master Dec 18, 2024
2 checks passed
@jonnor jonnor deleted the cnn-fix-output branch December 18, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant