Move PROXY_TO_PTHREAD handling into native code. NFC #17153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
tlively
approved these changes
Jun 3, 2022
dschuff
reviewed
Jun 3, 2022
sbc100
added a commit
that referenced
this pull request
Jun 6, 2022
Sometimes it is useful to be able to make the runtime as alive without also unwinding. See test_pthread_proxying_cpp.cpp for an example of this. I also have use case for emscripten_runtime_keepalive_check() in #17153
sbc100
added a commit
that referenced
this pull request
Jun 6, 2022
Sometimes it is useful to be able to make the runtime as alive without also unwinding. See test_pthread_proxying_cpp.cpp for an example of this. I also have use case for emscripten_runtime_keepalive_check() in #17153
sbc100
added a commit
that referenced
this pull request
Jun 6, 2022
Sometimes it is useful to be able to make the runtime as alive without also unwinding. See `test_pthread_proxying_cpp.cpp` for an example of this. I also have use case for emscripten_runtime_keepalive_check() in #17153
sbc100
force-pushed
the
proxy_main
branch
3 times, most recently
from
6ef0530 to
0a01279
Compare
sbc100
force-pushed
the
proxy_main
branch
2 times, most recently
from
05452d8 to
3697137
Compare
sbc100
added a commit
that referenced
this pull request
Jun 29, 2022
This was broken in #17153 but we didn't have any tests.
sbc100
added a commit
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17144