Mistral DL with doucmentation #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Mistral OCR Document Loader along with associated tests and documentation.
- Introduces the DocumentLoaderMistralOCR and MistralOCRConfig classes.
- Updates module exports and documentation to include the new loader.
- Adds new tests to validate configuration, URL, file, and BytesIO processing for Mistral OCR.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_extractor.py | Adds a main block for manual testing; however, contains undefined variable issues and a misnamed loader instance. |
| tests/test_document_loader_mistral_ocr.py | New test cases for validating the Mistral OCR loader functionality. |
| extract_thinker/document_loader/document_loader_mistral_ocr.py | Implements the new Mistral OCR loader with payload preparation, file upload, and pagination support. |
| extract_thinker/init.py | Updates module exports to include the new Mistral OCR loader and its configuration. |
| docs/core-concepts/document-loaders/mistral-ocr.md | Provides comprehensive documentation and usage examples for the Mistral OCR loader. |
|
|
||
| if __name__ == "__main__": | ||
|
|
||
| pdf_path = os.path.join(cwd, "tests", "files", "invoice.pdf") |
There was a problem hiding this comment.
The variable 'cwd' is not defined; consider using os.getcwd() to obtain the current working directory.
| pdf_path = os.path.join(cwd, "tests", "files", "invoice.pdf") | ||
|
|
||
| extractor = Extractor() | ||
| extractor.load_document_loader(DocumentLoaderDocling()) |
There was a problem hiding this comment.
The class 'DocumentLoaderDocling' appears to be a typo or misreference; update it to 'DocumentLoaderAWSTextract' as imported.
Suggested change
| extractor.load_document_loader(DocumentLoaderDocling()) | |
| extractor.load_document_loader(DocumentLoaderAWSTextract()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.