Skip to content

make espota compatible with python 3.5 #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2016
Merged

make espota compatible with python 3.5 #1492

merged 1 commit into from
Jan 25, 2016

Conversation

asdwsda
Copy link
Contributor

@asdwsda asdwsda commented Jan 24, 2016

With python 3.5 (default on Arch linux) I got the following:

Traceback (most recent call last):
  File "espota.py", line 318, in <module>
    sys.exit(main(sys.argv))
  File "espota.py", line 313, in main
    return serve(options.esp_ip, options.host_ip, options.esp_port, options.host_port, options.auth, options.image, command)
  File "espota.py", line 95, in serve
    sent = sock2.sendto(message, remote_address)
TypeError: a bytes-like object is required, not 'str'

This patch will fix the error. Tested with python 2.7.11 and 3.5.1.

igrr added a commit that referenced this pull request Jan 25, 2016
make espota compatible with python 3.5
@igrr igrr merged commit 5708c69 into esp8266:master Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants