Skip to content

espota: fixed remaining python 3.5 incompatibility #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2016

Conversation

asdwsda
Copy link
Contributor

@asdwsda asdwsda commented Jan 25, 2016

Sadly I didn't use authentication for ArduinoOTA so far. When I tried it turned out that it doesn't work with python 3.5...

Traceback (most recent call last):
  File "/home/bitn/.arduino15/packages/esp8266/hardware/esp8266/2.0.0/tools/espota.py", line 318, in <module>
    sys.exit(main(sys.argv))
  File "/home/bitn/.arduino15/packages/esp8266/hardware/esp8266/2.0.0/tools/espota.py", line 313, in main
    return serve(options.esp_ip, options.host_ip, options.esp_port, options.host_port, options.auth, options.image, command)
  File "/home/bitn/.arduino15/packages/esp8266/hardware/esp8266/2.0.0/tools/espota.py", line 107, in serve
    cnonce = hashlib.md5(cnonce_text).hexdigest()
TypeError: Unicode-objects must be encoded before hashing

Fixed the error and tested with python 2.7.11 and 3.5.1 as before. Everything worked fine with all the parameters, so I hope these were the last ones.
Sorry for the double pull request.

igrr added a commit that referenced this pull request Jan 26, 2016
espota: fixed remaining python 3.5 incompatibility
@igrr igrr merged commit 017dbc0 into esp8266:master Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants