cmd/geth: corrently init gas price for CLI CPU mining #14677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The miner can be started via 3 different ways:
--mineminer.starteth.getWorkThe latter two called
eth.PrivateMinerAPI.Start, which correctly raised the minimum gas price of the txpool from 1 Wei to whatever was configured in the CLI--gasprice. The former however started the miner directly, not via the API, and didn't update the txpool gas. As such, it kept using the 1 Wei gas limit.This issue does not affect mainnet, as it's only relevant for CLI mining, which can only do CPU mining.