Hot reloading: Avoid stack overflow on wide trees #34145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every sibling added to the stack here. Not sure this needs to be recursive at all but certainly for siblings this can just be a loop.
github-actions
bot
added
the
React Core Team
|
Comparing: 3958d5d...2c7a6df Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gaearon
approved these changes
Aug 9, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 10, 2025
Every sibling added to the stack here. Not sure this needs to be recursive at all but certainly for siblings this can just be a loop. DiffTrain build for [cf6e502](facebook@cf6e502)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 10, 2025
Every sibling added to the stack here. Not sure this needs to be recursive at all but certainly for siblings this can just be a loop. DiffTrain build for [cf6e502](facebook@cf6e502)
This was referenced Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every sibling added to the stack here. Not sure this needs to be recursive at all but certainly for siblings this can just be a loop.