-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Preserve remote URIs (e.g. s3://) in DaskOfflineStore path #5208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Preserve remote URIs (e.g. s3://) in DaskOfflineStore path #5208
Conversation
Please sign the commit so that DCO commit pass |
9356173
to
806d0c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@predictorsSH There is 1 more instance in the same file where absolute path is not correctly set up https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/offline_stores/dask.py#L472 |
Thanks! I've applied the same fix to |
@predictorsSH can you run the linter? |
I've applied the formatting using make format-python |
Hello, is there any updates? |
No further updates from my side. |
@predictorsSH Sorry, can you tell when the fix will be available? Or will the problem not be fixed at all? |
@predictorsSH can you please rebase (and squash, if possible) ? Once CI passed, we can get it merged. |
Can you please tell me the approximate time when the fix will be? We are really looking forward to it. Thank you! |
… resolution Signed-off-by: sanghyun <[email protected]>
9783043
to
9bab3d2
Compare
… resolution
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc