Skip to content

Conversation

@rhodgkins
Copy link
Contributor

Description

See firebase/firebase-functions#926

Will be fixed once that is merged in and the firebase-function dependency updated.

Code sample

See test case

  it('should allow null child value in makeDataSnapshot', async () => {
    const snapshot = makeDataSnapshot({ foo: null }, 'path');

    expect(snapshot.exists()).be.false;
    expect(snapshot.val()).to.deep.equal(null);
    expect(snapshot.ref.key).to.equal('path');
  });

@rhodgkins rhodgkins force-pushed the datasnapshot-null-children branch from 3648691 to f98db28 Compare August 19, 2021 07:39
@rhodgkins rhodgkins force-pushed the datasnapshot-null-children branch from f98db28 to 5753334 Compare August 9, 2022 16:12
@rhodgkins
Copy link
Contributor Author

Frustratingly the required changes to fix this have been pushed back to v4 of firebase-functions.

@rhodgkins
Copy link
Contributor Author

Failing test case now passes - this change is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant