Skip to content

replacing FSTGetTokenResult by C++ Token implementation #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zxu123 merged 10 commits into from
Feb 20, 2018
Merged

replacing FSTGetTokenResult by C++ Token implementation #805

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dc4f02c
replacing Auth/FSTUser by C++ auth implementation
zxu123 Feb 15, 2018
b502b8e
address changes
zxu123 Feb 15, 2018
bfbb0e2
replacing FSTGetTokenResult by C++ Token implementation
zxu123 Feb 15, 2018
a64ca8c
Merge branch 'master' into cpp/port_token
zxu123 Feb 15, 2018
9fb7911
address changes
zxu123 Feb 16, 2018
369f812
address changes
zxu123 Feb 16, 2018
6e4fdef
fix another const& v.s. dispatch bug
zxu123 Feb 16, 2018
5cb11ca
fix more const& v.s. dispatch bug zxu123 committed
zxu123 Feb 16, 2018
6775d9b
fix
zxu123 Feb 16, 2018
7d10621
passing by value in callback
zxu123 Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix more const& v.s. dispatch bug zxu123 committed
  • Loading branch information
@zxu123
zxu123 committed Feb 16, 2018
commit 5cb11cae69f226900502faa8023a42e8a3f003dd
5 changes: 3 additions & 2 deletions Firestore/Source/Remote/FSTDatastore.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ - (void)invokeRPCWithFactory:(GRPCProtoCall * (^)(void))rpcFactory
[self.credentials
getTokenForcingRefresh:NO
completion:^(const Token &result, NSError *_Nullable error) {
const Token resultCopy = result;
error = [FSTDatastore firestoreErrorForError:error];
[self.workerDispatchQueue dispatchAsyncAllowingSameQueue:^{
if (error) {
Expand All @@ -313,8 +314,8 @@ - (void)invokeRPCWithFactory:(GRPCProtoCall * (^)(void))rpcFactory
[FSTDatastore
prepareHeadersForRPC:rpc
databaseID:&self.databaseInfo->database_id()
token:(result.is_valid() ? result.token()
: absl::string_view())];
token:(resultCopy.is_valid() ? resultCopy.token()
: absl::string_view())];
[rpc start];
}
}];
Expand Down