[Auth] Add phone factor ID to the PhoneMultiFactorGenerator object #5487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-gc
requested review from
avolkovi,
lisajian and
yuchenshi
as code owners
🦋 Changeset detectedLatest commit: 7c8d507 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
lisajian
approved these changes
Sep 13, 2021
sam-gc
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
kevinthecheung
approved these changes
Sep 13, 2021
yuchenshi
approved these changes
Sep 14, 2021
sam-gc
force-pushed
the
sam-gc/phonegenerator
branch
from
bd13182 to
6316151
Compare
hsubox76
approved these changes
Sep 16, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5480
We were missing the static
FACTOR_IDfield that is present in v8