Skip to content

fix(app-check, web): More explicit interop types #17810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelVerdon merged 7 commits into from
Oct 24, 2025
Merged

fix(app-check, web): More explicit interop types #17810

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4331a08
fix(app-check, web): More explicit interop types
MichaelVerdon Oct 23, 2025
d8be8fd
fix: types
MichaelVerdon Oct 23, 2025
6aae501
format: app-check
MichaelVerdon Oct 23, 2025
df5eb49
chore: fix format
MichaelVerdon Oct 23, 2025
2c65768
fix: format
MichaelVerdon Oct 23, 2025
36e544d
chore: unskip web test
MichaelVerdon Oct 24, 2025
c4aa38f
fix: unskip tests
MichaelVerdon Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix format
  • Loading branch information
@MichaelVerdon
MichaelVerdon committed Oct 23, 2025
commit df5eb498928fd38f9b0063abd4632e53cbe4d9d1
6 changes: 4 additions & 2 deletions packages/firebase_app_check/firebase_app_check_web/lib/src/interop/app_check.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ class AppCheck extends JsObjectWrapper<app_check_interop.AppCheckJsImpl> {
);

Future<app_check_interop.AppCheckTokenResultJsImpl> getToken(
bool? forceRefresh) =>
bool? forceRefresh,
) =>
app_check_interop.getToken(jsObject, forceRefresh?.toJS).toDart;

Future<app_check_interop.AppCheckTokenResultJsImpl> getLimitedUseToken() =>
Expand Down Expand Up @@ -90,7 +91,8 @@ class AppCheck extends JsObjectWrapper<app_check_interop.AppCheckJsImpl> {
}

Stream<app_check_interop.AppCheckTokenResultJsImpl> onTokenChanged(
String appName) {
String appName,
) {
final appCheckWindowsKey = _appCheckWindowsKey(appName);
unsubscribeWindowsListener(appCheckWindowsKey);
if (_idTokenChangedController == null) {
Expand Down
1 change: 1 addition & 0 deletions packages/firebase_app_check/firebase_app_check_web/lib/src/interop/app_check_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class ReCaptchaV3Provider implements ReCaptchaProvider {
class ReCaptchaEnterpriseProvider implements ReCaptchaProvider {
external factory ReCaptchaEnterpriseProvider(JSString recaptchaKey);
}

extension type AppCheckTokenResultJsImpl._(JSObject _) implements JSObject {
external JSString get token;
}
Expand Down
Loading