This repository was archived by the owner on Apr 30, 2018. It is now read-only.
added support for description to all form fields #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this is awesome a11y for the win! I noticed that the formatting of some of the files is a little off. Could you fix that before it's merged in? Thanks for doing this! |
|
Should be fixed now I hope. |
|
Looks perfect. Thanks again for doing this @jonespen. Hopefully someone will merge this soon (I'm just a community contributor, so I can't merge it myself). |
|
This looks awesome @jonespen, I'll make sure it's in the next release, 0.0.15. |
|
Reopened as https://github.com/nimbly/angular-formly/pull/56 in the 0.0.15 branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves GH-52.
Note on the
aria-describedbyattributes: There is a a11y plugin in the making, which would remove this attribute if description is empty, but currently I haven't found a (good) solution to this problem.Edit: gah, sorry for the messed up spaces/tabs. feel free to fix before merge ;)