-
Notifications
You must be signed in to change notification settings - Fork 2
Update all dependencies + fix ensureRegistered bug #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #84 will not alter performanceComparing 🎉 Hooray!
|
Oof, that's a rough regression. Lemme see if it's an easy fix, or if we don't bump. [EDIT] [EDIT 2] |
d500123
to
62fe068
Compare
Except two: 1. deep-freeze-es6, which jest is unhappy with for any version >= 2. 1. eslint, which broke a lot of things in v9.
This values is the number of times to run a benchmark before recording values. It defaults to 1, but we want to have it be a high enough number to be more likely to warm up the JIT so that benchmarks will likely be a bit fairer across branches. I'm not sure what a good value is, so this is very "finger in the wind".
☝️ rebasing to test the new benchmarks against |
We had to patch out this change from the MST release in Gadget core, but that's because we do a ton of work with patches directly. All fixable, but that allows us to make progress more quickly. I think it's worth keeping these up to date though, so I'll leave the version bumps in! |
I packed a bunch of stuff into one PR, but split it up into separate commits:
for it to settle and the plugin ecosystem to support v9.
type
argument passed toensureRegistered
for registration, and not each part of the prototype chain.initCount
in our benchmarks so that we don't get any unfortunate issues where a benchmark has some JITed and non-JITed samples. Not sure if the value is high enough to ensure things will be JIT-ed, but I figure it's still an improvement.TODO