fix: use forked devcert to avoid pulling transitive deps from its @types/* deps, handle change in tmp package #39343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
force-pushed
the
fix/indirect-devcert-deps-requiring-node-20
branch
from
cdeeb46 to
06d79aa
Compare
pieh
force-pushed
the
fix/indirect-devcert-deps-requiring-node-20
branch
from
ce44fd0 to
32f56c8
Compare
pieh
commented
Aug 6, 2025
Comment on lines
+60
to
+64
|
|
||
| const dotCachePath = path.join(process.cwd(), `.cache`) | ||
| fs.mkdirpSync(dotCachePath) | ||
| const tmpFileName = tmp.tmpNameSync({ | ||
| tmpdir: path.join(process.cwd(), `.cache`), | ||
| tmpdir: dotCachePath, |
Contributor
Author
There was a problem hiding this comment.
raszi/node-tmp@1cf4ec5#diff-1cf97fc30a5d84b74b60007e190ead611730d702c2dd9d353586dfa16862bb5dR29-R486 this change that was recently released in tmp package make it so provided tmpdir need to exist, while previous patch version of package didn't need that
so instead of pinning, I just ensure dir exist
pieh
changed the title
pieh
added a commit
that referenced
this pull request
Aug 6, 2025
…pes/* deps, handle change in tmp package (#39343) * fix: use forked devcert to avoid pulling transitive deps from its @types/* deps * chore: remove cpy from structured-logging test * chore: remove del-cli from cli test * chore: use gatsbyjs fork and not private one * chore: use @expo/devcert as it is being maintained * fix: create .cache directory before trying to create temp file in it (cherry picked from commit 4b1be67)
pieh
added a commit
that referenced
this pull request
Aug 6, 2025
…pes/* deps, handle change in tmp package (#39343) (#39345) * fix: use forked devcert to avoid pulling transitive deps from its @types/* deps * chore: remove cpy from structured-logging test * chore: remove del-cli from cli test * chore: use gatsbyjs fork and not private one * chore: use @expo/devcert as it is being maintained * fix: create .cache directory before trying to create temp file in it (cherry picked from commit 4b1be67) Co-authored-by: Michal Piechowiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gatsbyjs/devcert@7085e48 is what is different, those@types/*deps being in deps, are being installed when gatsby is installed and they contain*version selectors sometimes pulling latest of packages that might not be compatible with node 18 that is still min version and needs to keep workinghttps://github.com/expo/devcert seems to be maintained fork, so instead of using our own, let's use this one
This also drops some test helper packages with similar problems and just use builtins
Documentation
Tests
Related Issues