-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: gcmarx/GitPython
base: f3ab5d3
head repository: gitpython-developers/GitPython
compare: 751cb2d
- 12 commits
- 11 files changed
- 3 contributors
Commits on May 22, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 8dc7552 - Browse repository at this point
Copy the full SHA 8dc7552View commit details
Commits on May 23, 2025
-
Merge pull request gitpython-developers#2028 from gcmarx/remove-type-…
…assertions remove type assertions from util.py
Configuration menu - View commit details
-
Copy full SHA for bf51609 - Browse repository at this point
Copy the full SHA bf51609View commit details
Commits on May 28, 2025
-
Merge pull request gitpython-developers#2026 from gcmarx/main
correctly handle `uname-cmd` that doesn't point to an executable file
Configuration menu - View commit details
-
Copy full SHA for 8576534 - Browse repository at this point
Copy the full SHA 8576534View commit details
Commits on May 30, 2025
-
This updates `ruff` in `.pre-commit-config.yaml` from 0.6.0 to 0.11.12, changes its `id` from the legacy `ruff` alias to `ruff-check` (which is better distinguished from `ruff-format`, which we also have a hook for), and applies the few style changes it newly recommends throughout the code. The style changes seem to make things slightly clearer overall. This also updates some other pre-commit hooks, but those don't require any changes to the code. Currently the `ruff` dependency in `requirements-dev.txt` doesn't specify a version, so no change is needed there. This update may be seen as bringing the `pre-commit` version in line with what users will usually have locally with `pip install -e ".[test]"`. The `pre-commit` hooks are how linting is currently done on CI, so this is updating `ruff` for CI. That's the most significant effect of this change. (`pre-commit` is run for linting on CI probably much more often than it is used locally, to manage pre-commit hooks or otherwise, in GitPython development.)
Configuration menu - View commit details
-
Copy full SHA for b7ce712 - Browse repository at this point
Copy the full SHA b7ce712View commit details -
Merge pull request gitpython-developers#2031 from EliahKagan/newer-ruff
Use newer ruff style
Configuration menu - View commit details
-
Copy full SHA for 2d662cc - Browse repository at this point
Copy the full SHA 2d662ccView commit details -
Temporarily remove CodeQL workflow file
So GitHub can regenerate a fresh new one based on current defaults.
Configuration menu - View commit details
-
Copy full SHA for 0c0fc7e - Browse repository at this point
Copy the full SHA 0c0fc7eView commit details -
Recreate
codeq.yml
with current defaultsThis adds CodeQL scanning of GitHub Actions, while continuing to scan Python as well. This will subsequently be customized slightly to restore some elements of the preivous custom workflow that we may prefer.
Configuration menu - View commit details
-
Copy full SHA for 847ead6 - Browse repository at this point
Copy the full SHA 847ead6View commit details -
Keep running CodeQL on all branches, etc.
This restores three aspects of the previous `codeql.yml`: - Run it on all branches, not just `main`. - Run it on the previous schedule rather than the new one, since there's no reason to change the schedule (though there's no reason to be attached to the old schedule either). - Use "CodeQL" rather than "CodeQL Advanced" as the workflow `name`, since this takes up less horizontal space when reading the reports from the checks. Of these, only the first is really significant.
Configuration menu - View commit details
-
Copy full SHA for d7ce09f - Browse repository at this point
Copy the full SHA d7ce09fView commit details -
Remove unnecessary permissions from
codeql.yml
This is another change back to the way we had it before, but the removals are based specifically on the guidance in the default workflow comments about why each permission was given by default.
Configuration menu - View commit details
-
Copy full SHA for 89dbd4a - Browse repository at this point
Copy the full SHA 89dbd4aView commit details -
Merge pull request gitpython-developers#2032 from EliahKagan/codeql-gha
Have CodeQL scan GitHub Actions workflows as well as Python code
Configuration menu - View commit details
-
Copy full SHA for 2e4a0d2 - Browse repository at this point
Copy the full SHA 2e4a0d2View commit details -
Specify explicit
contents: read
workflow permissionsThree CI workflows that need only `contents: read` permissions and no other permissions did not have explicit permissions set, and would therefore be given default permissions configured for the repository, which might be more expansive than the workflows need. It is recommended to set explicit workflow permissions [1]. This does that, specifying permissions as `pythonpackage.yml` already did, and closing three `actions/missing-workflow-permissions` CodeQL alerts (new since gitpython-developers#2032 enabled scanning of GHA workflows). [1]: https://codeql.github.com/codeql-query-help/actions/actions-missing-workflow-permissions/
Configuration menu - View commit details
-
Copy full SHA for a9833d6 - Browse repository at this point
Copy the full SHA a9833d6View commit details -
Merge pull request gitpython-developers#2033 from EliahKagan/gha-perm…
…issions Specify explicit `contents: read` workflow permissions
Configuration menu - View commit details
-
Copy full SHA for 751cb2d - Browse repository at this point
Copy the full SHA 751cb2dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff f3ab5d3...751cb2d