Skip to content

CODE OPTIMIZATION #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2023
Merged

CODE OPTIMIZATION #1943

merged 3 commits into from
Jul 27, 2023

Conversation

OfficialAhmed
Copy link
Contributor

  • Implemented match-case for enhanced performance instead of if-else -> Faster by 86% ( match-case benchmark )
  • Consolidating checks into a dynamic function, setZeroFlag:
    Combine multiple checks into a single dynamic function, setZeroFlag which takes token and tmpToken as arguments and returns a bool to set the zero flag

Copy link
Contributor

@NitkarshChourasia NitkarshChourasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderfully used match case to make the code more readable and standardized.
Thus, the code is more properly formatted.

@NitkarshChourasia
Copy link
Contributor

Good, use of if and else cases.

@NitkarshChourasia
Copy link
Contributor

instead of it you used match case, good.

@geekcomputers geekcomputers merged commit 64e418b into geekcomputers:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants