Skip to content

Update site landing page #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2016
Merged

Update site landing page #9

merged 2 commits into from
Oct 13, 2016

Conversation

vicchi
Copy link
Member

@vicchi vicchi commented Oct 11, 2016

This should now reflect the current set of providers across the main and extras project

@vicchi vicchi mentioned this pull request Oct 11, 2016
Closed
@vicchi
Copy link
Member Author

vicchi commented Oct 12, 2016 •
edited
Loading

@willdurand - the Travis build is having exactly the same problems installing as I was on my local machine. Are you able to get a working Jekyll build up and running to test this?

There seems to be an issue with Jekyll; I've just spun up a clean VM and installed Jekyll and all dependencies and I'm still getting a build error.

$ bundle exec jekyll serve
Configuration file: /vagrant/_config.yml
            Source: /vagrant
       Destination: /vagrant/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
    Liquid Warning: Liquid syntax error (line 51): Unexpected character   in "{{ site.url }}" in index.markdown
  Dependency Error: Yikes! It looks like you don't have redcarpet or one of its dependencies installed. In order to use Jekyll as currently configured, you'll need to install this gem. The full error message from Ruby is: 'cannot load such file -- redcarpet' If you run into trouble, you can find helpful resources at http://jekyllrb.com/help/! 
  Conversion error: Jekyll::Converters::Markdown encountered an error while converting 'index.markdown':
                    redcarpet
             ERROR: YOUR SITE COULD NOT BE BUILT:
                    ------------------------------------
                    redcarpet

@vicchi
Copy link
Member Author

vicchi commented Oct 12, 2016

This looks like the source of the issue - https://github.com/blog/2100-github-pages-jekyll-3

tl;dr - redcarpet support has been obsoleted and replaced with kramdown for Markdown rendering.

Sure enough, modifying the site's _config.yml to use kramdown seems to work, but there's some warnings from Jekyll 3 which I want to tidy up first.

Watch this space

@vicchi
Update site configuration to support Jekyll 3.0 (mandatory for GitHub…
d319cc0 
… Pages)

Ignore transient gem files

Migrate from Pygments to Rouge as part of Jekyll 3.0 support

Fix Liquid warnings due to non-printing characters in tags

Remove reference to (non-existent) cookbook
@vicchi
Copy link
Member Author

vicchi commented Oct 13, 2016

@willdurand Fixed the site build issues and upgraded to support Jekyll 3.0. All building cleanly now. Could you take a look at this PR and merge please?

@willdurand
Copy link
Member

Awesome! ❤️

@willdurand willdurand merged commit 6159ec8 into geocoder-php:master Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicchi @willdurand