docs: provide information for SENTRY_AIR_GAP flag on Django config file #3935
Conversation
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3935 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 3 3
Lines 197 197
=======================================
Hits 196 196
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Amin Vakil <[email protected]>
Co-authored-by: Amin Vakil <[email protected]>
|
@aldy505 I think you wanted a review from someone else and asked me by mistake again. |
No, that was a race condition. You approve before I re-requested the review. |
#14924) …llation <!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR In accordance with getsentry/self-hosted#3935 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
| # Setting the value to False while running in an air-gapped environment will | ||
| # cause some containers to raise exceptions. One known example is fetching | ||
| # AI model prices from various public APIs. | ||
| SENTRY_AIR_GAP = False |
There was a problem hiding this comment.
I feel like this should come from an env variable?
There was a problem hiding this comment.
Too much environment variables.
There was a problem hiding this comment.
But this airgap setting may need to be a global setting for the entire deploy (like retention days)
There was a problem hiding this comment.
I believe no. Since the current settings is strictly just for acquiring AI model prices.
There was a problem hiding this comment.
Okay I'll let you deal with this when it happens in the future 🤣
4 participants
Corresponding PR: getsentry/sentry#99281